Bug 37319 - Move mappings for 752ad (MARC21) and 210a/214a (UNIMARC) to pl index
Summary: Move mappings for 752ad (MARC21) and 210a/214a (UNIMARC) to pl index
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching - Elasticsearch (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Janusz Kaczmarek
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 36578
Blocks:
  Show dependency treegraph
 
Reported: 2024-07-10 20:53 UTC by Caroline Cyr La Rose
Modified: 2024-07-12 08:22 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37319: Move mappings for 752ad (MARC21) and 210a/214a (UNIMARC) to pl index (2.21 KB, patch)
2024-07-11 09:17 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 37319: Move mappings for 752ad (MARC21) and 210a/214a (UNIMARC) to pl index (2.29 KB, patch)
2024-07-11 14:03 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-07-10 20:53:17 UTC
In Bug 36578, some fields were added to the pl index, but somehow it ended up in the other-control-number index. This aims to put fields 752ad (MARC21) and 210a/214a (UNIMARC) in the pl index.
Comment 1 Janusz Kaczmarek 2024-07-11 09:17:14 UTC
Created attachment 168780 [details] [review]
Bug 37319: Move mappings for 752ad (MARC21) and 210a/214a (UNIMARC) to pl index

In Bug 36578, some fields were added to the pl index, but somehow it
ended up in the other-control-number index. This aims to put fields
752ad (MARC21) and 210a/214a (UNIMARC) in the pl index.

Test plan:
----------
0. Have an installation with Elasticsearch and MARC 21 configuration.
1. Under  Administration > Search engine configuration (Elasticsearch)
   under the tab Bibliographic records check that you have 752ad in
   other-control-number search field.
2. Apply the patch, reindex with:
   sudo koha-elasticsearch --rebuild -r -b kohadev
3. Under  Administration > Search engine configuration (Elasticsearch)
   under the tab Bibliographic records check that you have 752ad in pl
   search field now.
Comment 2 Janusz Kaczmarek 2024-07-11 09:19:15 UTC
Thanks Caroline for catching that!
Comment 3 Caroline Cyr La Rose 2024-07-11 14:03:21 UTC
Created attachment 168826 [details] [review]
Bug 37319: Move mappings for 752ad (MARC21) and 210a/214a (UNIMARC) to pl index

In Bug 36578, some fields were added to the pl index, but somehow it
ended up in the other-control-number index. This aims to put fields
752ad (MARC21) and 210a/214a (UNIMARC) in the pl index.

Test plan:
----------
0. Have an installation with Elasticsearch and MARC 21 configuration.
1. Under  Administration > Search engine configuration (Elasticsearch)
   under the tab Bibliographic records check that you have 752ad in
   other-control-number search field.
2. Apply the patch, reindex with:
   sudo koha-elasticsearch --rebuild -r -b kohadev
3. Under  Administration > Search engine configuration (Elasticsearch)
   under the tab Bibliographic records check that you have 752ad in pl
   search field now.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 4 Caroline Cyr La Rose 2024-07-11 14:05:35 UTC
Thanks Janusz! I had done the correction last night but got stuck at figuring out/writing out the test plan. It's one of those cases where the correction is waaaay faster than the test ;)
Comment 5 Katrin Fischer 2024-07-12 07:43:17 UTC
Thanks for the quick fix!
Comment 6 Katrin Fischer 2024-07-12 08:22:26 UTC
Pushed for 24.11!

Well done everyone, thank you!