| Summary: | Cannot save default display length or default sort order in table settings | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | System Administration | Assignee: | Lucas Gass (lukeg) <lucas> |
| Status: | Needs documenting --- | QA Contact: | Pedro Amorim <pedro.amorim> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, pedro.amorim |
| Version: | Main | Keywords: | regression |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 35883 | ||
| Bug Blocks: | 36096 | ||
| Attachments: |
Bug 36592: Fix default display lenght and default sort
Bug 36592: Fix default display lenght and default sort Bug 36592: Fix default display lenght and default sort |
||
|
Description
Lucas Gass (lukeg)
2024-04-12 09:43:20 UTC
In columns_settings.pl there is this check: next unless $table_id =~ m|^([^#]*)#(.*)$|; which checks and passes table_id's named like this: acq_acqui-home#accounts but the tables are being like this: acq_acqui-home_accounts Created attachment 164833 [details] [review] Bug 36592: Fix default display lenght and default sort To test: 1. Go to Admin > Table settings 2. Find a table that includes Default display length or Default sort order. 3. Try to save a new value. 4. When the page reloads the new values have not been saved. 5. APPLY PATCH 6. Try 1 -3 again, this time the value should save correctly. 7. Go to Admin > Table settings and make sure the accordians still work and the in page links in each section still work. Created attachment 164849 [details] [review] Bug 36592: Fix default display lenght and default sort To test: 1. Go to Admin > Table settings 2. Find a table that includes Default display length or Default sort order. 3. Try to save a new value. 4. When the page reloads the new values have not been saved. 5. APPLY PATCH 6. Try 1 -3 again, this time the value should save correctly. 7. Go to Admin > Table settings and make sure the accordians still work and the in page links in each section still work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 165379 [details] [review] Bug 36592: Fix default display lenght and default sort To test: 1. Go to Admin > Table settings 2. Find a table that includes Default display length or Default sort order. 3. Try to save a new value. 4. When the page reloads the new values have not been saved. 5. APPLY PATCH 6. Try 1 -3 again, this time the value should save correctly. 7. Go to Admin > Table settings and make sure the accordians still work and the in page links in each section still work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Pushed for 24.05! Well done everyone, thank you! |