Bug 36605

Summary: TrackLastPatronActivity for SIP should track both patron status and patron information requests
Product: Koha Reporter: Nick Clemens (kidclamp) <nick>
Component: SIP2Assignee: Nick Clemens (kidclamp) <nick>
Status: Pushed to oldstable --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, lucas, magnus
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00,23.11.06,23.05.12
Circulation function:
Bug Depends on:    
Bug Blocks: 38284    
Attachments: Bug 36605: Add update_lastseen to handle_patron_status for SIP
Bug 36605: Add update_lastseen to handle_patron_status for SIP
Bug 36605: [23.05.x] Add update_lastseen to handle_patron_status for SIP

Description Nick Clemens (kidclamp) 2024-04-16 03:49:33 UTC
OverDrive now uses the patron status request for verifying patrons. Previously they used the patron information request. This change has caused patrons last seen date to not be updated by OverDrive logins.

To fix this, we should extend the functionality of TrackLastPatronActivity for SIP/ILSDI to include the status request
Comment 1 Nick Clemens (kidclamp) 2024-04-16 03:52:17 UTC
Created attachment 164897 [details] [review]
Bug 36605: Add update_lastseen to handle_patron_status for SIP

This patch extends the TrackLastPatronActivity trigger to cover SIP status messages as well.
Other SIP messages like Checkin/Checkout should be covered by those values in system preference, so
should not need adjustment.

To test:
prove -v t/db_dependent/SIP/Message.t
Comment 2 Martin Renvoize (ashimema) 2024-04-16 06:29:32 UTC
Created attachment 164898 [details] [review]
Bug 36605: Add update_lastseen to handle_patron_status for SIP

This patch extends the TrackLastPatronActivity trigger to cover SIP status messages as well.
Other SIP messages like Checkin/Checkout should be covered by those values in system preference, so
should not need adjustment.

To test:
prove -v t/db_dependent/SIP/Message.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize (ashimema) 2024-04-16 06:30:06 UTC
Obvious use case here, works as described and is well tested.

Going straight for QA
Comment 4 Katrin Fischer 2024-04-29 07:44:08 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Nick Clemens (kidclamp) 2024-04-30 16:24:32 UTC
Created attachment 165921 [details] [review]
Bug 36605: [23.05.x] Add update_lastseen to handle_patron_status for SIP
Comment 6 Nick Clemens (kidclamp) 2024-04-30 16:25:50 UTC
TrackLastPatronActivityTriggers is only 23.11+ - 23.05 version supplied
Comment 7 Fridolin Somers 2024-05-24 09:41:06 UTC
More a bug than enhancement ;)

Pushed to 23.11.x for 23.11.06
Comment 8 Lucas Gass (lukeg) 2024-05-28 21:04:20 UTC
Backported to 23.05.x for upcoming 23.05.12