Bug 36605 - TrackLastPatronActivity for SIP should track both patron status and patron information requests
Summary: TrackLastPatronActivity for SIP should track both patron status and patron in...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Nick Clemens (kidclamp)
QA Contact: Martin Renvoize
URL:
Keywords: release-notes-needed
Depends on:
Blocks:
 
Reported: 2024-04-16 03:49 UTC by Nick Clemens (kidclamp)
Modified: 2024-04-30 16:25 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.00


Attachments
Bug 36605: Add update_lastseen to handle_patron_status for SIP (4.50 KB, patch)
2024-04-16 03:52 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 36605: Add update_lastseen to handle_patron_status for SIP (4.75 KB, patch)
2024-04-16 06:29 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 36605: [23.05.x] Add update_lastseen to handle_patron_status for SIP (4.06 KB, patch)
2024-04-30 16:24 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2024-04-16 03:49:33 UTC
OverDrive now uses the patron status request for verifying patrons. Previously they used the patron information request. This change has caused patrons last seen date to not be updated by OverDrive logins.

To fix this, we should extend the functionality of TrackLastPatronActivity for SIP/ILSDI to include the status request
Comment 1 Nick Clemens (kidclamp) 2024-04-16 03:52:17 UTC
Created attachment 164897 [details] [review]
Bug 36605: Add update_lastseen to handle_patron_status for SIP

This patch extends the TrackLastPatronActivity trigger to cover SIP status messages as well.
Other SIP messages like Checkin/Checkout should be covered by those values in system preference, so
should not need adjustment.

To test:
prove -v t/db_dependent/SIP/Message.t
Comment 2 Martin Renvoize 2024-04-16 06:29:32 UTC
Created attachment 164898 [details] [review]
Bug 36605: Add update_lastseen to handle_patron_status for SIP

This patch extends the TrackLastPatronActivity trigger to cover SIP status messages as well.
Other SIP messages like Checkin/Checkout should be covered by those values in system preference, so
should not need adjustment.

To test:
prove -v t/db_dependent/SIP/Message.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2024-04-16 06:30:06 UTC
Obvious use case here, works as described and is well tested.

Going straight for QA
Comment 4 Katrin Fischer 2024-04-29 07:44:08 UTC
Pushed for 24.05!

Well done everyone, thank you!
Comment 5 Nick Clemens (kidclamp) 2024-04-30 16:24:32 UTC
Created attachment 165921 [details] [review]
Bug 36605: [23.05.x] Add update_lastseen to handle_patron_status for SIP
Comment 6 Nick Clemens (kidclamp) 2024-04-30 16:25:50 UTC
TrackLastPatronActivityTriggers is only 23.11+ - 23.05 version supplied