Summary: | The old googleopenidconnect service should redirect to page that initiated login | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicholas van Oudtshoorn <vanoudt> |
Component: | Authentication | Assignee: | Nicholas van Oudtshoorn <vanoudt> |
Status: | Failed QA --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | dcook, dpavlin, lisette, shi-yao.wang |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34164 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | Allow old googleopenidconnect service to redirect to referring page if possible and appropriate. |
Description
Nicholas van Oudtshoorn
2024-04-17 08:16:20 UTC
Created attachment 164981 [details] [review] Allow old googleopenidconnect service to redirect to referring page if possible and appropriate. Can we get a test plan in the commit message with this? https://wiki.koha-community.org/wiki/Commit_messages (In reply to Shi Yao Wang from comment #2) > Can we get a test plan in the commit message with this? > https://wiki.koha-community.org/wiki/Commit_messages Yes, please provide a test plan. Looking at this and bug 34164... this code should be in its own function in a Perl module. For example: my $koha_referrer = C4::Context::koha_referrer({ interface => $interface, referrer_url => $referrer_url, }); -- Also, the issues Lukas Koszyk mentions on bug 34164 should also be addressed. These will also be easier to address when using a dedicated function in a Perl module. -- I've used the C4::Context module here, since the referrer is specific to the web context. I suppose you could make an argument that it should be in a Koha::Auth:: module instead. Heck... maybe even Koha::Auth::Referrer. -- Anyway, I'm not trying to dictate how it should go. Just that the code should be in its own function in a Perl module so that it's not duplicated and so that it's easily tested :) |