Splitting bug 34164 up, with this bug referring to the old googleopenidconnect service. At the moment, a successful googleopenidconnect login is sent to opac-user.pl/opac-main.pl or mainpage.pl instead of the page that initiated the login process.
Created attachment 164981 [details] [review] Allow old googleopenidconnect service to redirect to referring page if possible and appropriate.
Can we get a test plan in the commit message with this? https://wiki.koha-community.org/wiki/Commit_messages
(In reply to Shi Yao Wang from comment #2) > Can we get a test plan in the commit message with this? > https://wiki.koha-community.org/wiki/Commit_messages Yes, please provide a test plan.
Looking at this and bug 34164... this code should be in its own function in a Perl module. For example: my $koha_referrer = C4::Context::koha_referrer({ interface => $interface, referrer_url => $referrer_url, }); -- Also, the issues Lukas Koszyk mentions on bug 34164 should also be addressed. These will also be easier to address when using a dedicated function in a Perl module. -- I've used the C4::Context module here, since the referrer is specific to the web context. I suppose you could make an argument that it should be in a Koha::Auth:: module instead. Heck... maybe even Koha::Auth::Referrer. -- Anyway, I'm not trying to dictate how it should go. Just that the code should be in its own function in a Perl module so that it's not duplicated and so that it's easily tested :)