Summary: | Remove localhost reference from counter logs page | ||
---|---|---|---|
Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
Component: | ERM | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, jonathan.field, lucas, martin.renvoize, matt.blenkinsop, pedro.amorim, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 36627 | ||
Attachments: |
Bug 36623: Remove localhost reference
Bug 36623: Fix translation Bug 36623:(follow-up) Fix cypress test |
Description
Matt Blenkinsop
2024-04-17 15:03:28 UTC
Created attachment 165023 [details] [review] Bug 36623: Remove localhost reference This patch removes a reference to localhost from a url within ERM Test plan: This is quite hard to test without sushi credentials and is quite an easy fix. Check the patch diff to verify that the localhost reference has now been removed from the url Very obvious and clear correction. Going straight for a PQA here. I believe this highlights an untranslatable string (Borrowernumber): ? `<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=${row.borrowernumber}">Borrowernumber ${row.borrowernumber}</a>` Please fix in a follow-up or on a separate new bug report. That is addressed in bug 36627 which embeds the patron and uses the patron name instead Can you please double check the file for other occurences? I think there is another: "Cronjob" Created attachment 165114 [details] [review] Bug 36623: Fix translation Pushed for 24.05! Well done everyone, thank you! Pushed for 24.05! Well done everyone, thank you! Created attachment 166767 [details] [review] Bug 36623:(follow-up) Fix cypress test Follow up pushed to main. Thanks! Pushed to 23.11.x for 23.11.06 Doesn't apply cleanly to 23.05.x, no backport. |