Bug 36627 - Display importer for manually harvested SUSHI data
Summary: Display importer for manually harvested SUSHI data
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Matt Blenkinsop
QA Contact:
URL:
Keywords:
Depends on: 36623
Blocks:
  Show dependency treegraph
 
Reported: 2024-04-17 16:22 UTC by Matt Blenkinsop
Modified: 2024-04-18 21:06 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Example counter file (869 bytes, text/csv)
2024-04-17 16:29 UTC, Matt Blenkinsop
Details
Bug 36627: Record who is importing sushi data (4.05 KB, patch)
2024-04-17 16:29 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36627: Embed patron record for display (2.30 KB, patch)
2024-04-17 16:29 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36627: Record who is importing sushi data (4.01 KB, patch)
2024-04-18 08:50 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36627: Embed patron record for display (2.30 KB, patch)
2024-04-18 08:50 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36627: Rename embed method to patron (4.91 KB, patch)
2024-04-18 09:23 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36627: Rename embed method to patron (5.00 KB, patch)
2024-04-18 09:24 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36627: Record who is importing sushi data (4.06 KB, patch)
2024-04-18 10:21 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36627: Embed patron record for display (2.35 KB, patch)
2024-04-18 10:21 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36627: Rename embed method to patron (5.05 KB, patch)
2024-04-18 10:21 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36627: Use patron_to_html in 'Imported by' column (1.98 KB, patch)
2024-04-18 10:21 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36627: Add tests (2.67 KB, patch)
2024-04-18 10:21 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36627: Record who is importing sushi data (4.06 KB, patch)
2024-04-18 10:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36627: Embed patron record for display (2.35 KB, patch)
2024-04-18 10:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36627: Rename embed method to patron (5.05 KB, patch)
2024-04-18 10:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36627: Use patron_to_html in 'Imported by' column (2.05 KB, patch)
2024-04-18 10:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36627: Add tests (2.67 KB, patch)
2024-04-18 10:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36627: Record who is importing sushi data (4.08 KB, patch)
2024-04-18 14:52 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36627: Embed patron record for display (2.36 KB, patch)
2024-04-18 14:52 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36627: Rename embed method to patron (5.06 KB, patch)
2024-04-18 14:52 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36627: Use patron_to_html in 'Imported by' column (2.07 KB, patch)
2024-04-18 14:52 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 36627: Add tests (2.68 KB, patch)
2024-04-18 14:52 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-04-17 16:22:46 UTC
The counter logs table has a column for "Imported by" but this is not currently stored
Comment 1 Matt Blenkinsop 2024-04-17 16:29:01 UTC
Created attachment 165029 [details]
Example counter file
Comment 2 Matt Blenkinsop 2024-04-17 16:29:50 UTC
Created attachment 165030 [details] [review]
Bug 36627: Record who is importing sushi data

This patch adds functionality for storing the patron (or cronjob) that triggers a harvest. Currently every counter log is stored as being imported by the cronjob

Test plan:
1) In the usage statistics module in ERM, create a data provider (the details in the provider are not important)
2) Click into the provider and click into manual upload
3) Upload the file attached to this bug
4) Once the background job is completed click into the counter logs tab in the provider. The imported by columns should show a user with a clickable link
Comment 3 Matt Blenkinsop 2024-04-17 16:29:52 UTC
Created attachment 165031 [details] [review]
Bug 36627: Embed patron record for display
Comment 4 Matt Blenkinsop 2024-04-18 08:50:03 UTC
Created attachment 165054 [details] [review]
Bug 36627: Record who is importing sushi data

This patch adds functionality for storing the patron (or cronjob) that triggers a harvest. Currently every counter log is stored as being imported by the cronjob

Test plan:
1) In the usage statistics module in ERM, create a data provider (the details in the provider are not important)
2) Click into the provider and click into manual upload
3) Upload the file attached to this bug
4) Once the background job is completed click into the counter logs tab in the provider. The imported by columns should show a user with a clickable link
Comment 5 Matt Blenkinsop 2024-04-18 08:50:05 UTC
Created attachment 165055 [details] [review]
Bug 36627: Embed patron record for display
Comment 6 Matt Blenkinsop 2024-04-18 09:23:29 UTC
Created attachment 165056 [details] [review]
Bug 36627: Rename embed method to patron

This patch renames the embed method from borrowernumber to patron to fit with the use of 'patron' in the API
Comment 7 Matt Blenkinsop 2024-04-18 09:24:58 UTC
Created attachment 165057 [details] [review]
Bug 36627: Rename embed method to patron

This patch renames the embed method from borrowernumber to patron to fit with the use of 'patron' in the API
Comment 8 Pedro Amorim 2024-04-18 10:21:11 UTC Comment hidden (obsolete)
Comment 9 Pedro Amorim 2024-04-18 10:21:14 UTC Comment hidden (obsolete)
Comment 10 Pedro Amorim 2024-04-18 10:21:16 UTC Comment hidden (obsolete)
Comment 11 Pedro Amorim 2024-04-18 10:21:19 UTC Comment hidden (obsolete)
Comment 12 Pedro Amorim 2024-04-18 10:21:22 UTC Comment hidden (obsolete)
Comment 13 Pedro Amorim 2024-04-18 10:26:28 UTC
Created attachment 165070 [details] [review]
Bug 36627: Record who is importing sushi data

This patch adds functionality for storing the patron (or cronjob) that triggers a harvest. Currently every counter log is stored as being imported by the cronjob

Test plan:
1) In the usage statistics module in ERM, create a data provider (the details in the provider are not important)
2) Click into the provider and click into manual upload
3) Upload the file attached to this bug
4) Once the background job is completed click into the counter logs tab in the provider. The imported by columns should show a user with a clickable link

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 14 Pedro Amorim 2024-04-18 10:26:35 UTC
Created attachment 165071 [details] [review]
Bug 36627: Embed patron record for display

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 15 Pedro Amorim 2024-04-18 10:26:38 UTC
Created attachment 165072 [details] [review]
Bug 36627: Rename embed method to patron

This patch renames the embed method from borrowernumber to patron to fit with the use of 'patron' in the API

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 16 Pedro Amorim 2024-04-18 10:26:40 UTC
Created attachment 165073 [details] [review]
Bug 36627: Use patron_to_html in 'Imported by' column

For consistency, and to avoid 'null koha' for a file imported by
the koha user (no first name).

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 17 Pedro Amorim 2024-04-18 10:26:43 UTC
Created attachment 165074 [details] [review]
Bug 36627: Add tests

k-t-d, from /kohadevbox/koha, run:
yarn run cypress run --spec "./t/cypress/integration/ERM/DataProviders_spec.ts"

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 18 Matt Blenkinsop 2024-04-18 14:52:28 UTC
Created attachment 165127 [details] [review]
Bug 36627: Record who is importing sushi data

This patch adds functionality for storing the patron (or cronjob) that triggers a harvest. Currently every counter log is stored as being imported by the cronjob

Test plan:
1) In the usage statistics module in ERM, create a data provider (the details in the provider are not important)
2) Click into the provider and click into manual upload
3) Upload the file attached to this bug
4) Once the background job is completed click into the counter logs tab in the provider. The imported by columns should show a user with a clickable link

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 19 Matt Blenkinsop 2024-04-18 14:52:31 UTC
Created attachment 165128 [details] [review]
Bug 36627: Embed patron record for display

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 20 Matt Blenkinsop 2024-04-18 14:52:33 UTC
Created attachment 165129 [details] [review]
Bug 36627: Rename embed method to patron

This patch renames the embed method from borrowernumber to patron to fit with the use of 'patron' in the API

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 21 Matt Blenkinsop 2024-04-18 14:52:36 UTC
Created attachment 165130 [details] [review]
Bug 36627: Use patron_to_html in 'Imported by' column

For consistency, and to avoid 'null koha' for a file imported by
the koha user (no first name).

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 22 Matt Blenkinsop 2024-04-18 14:52:38 UTC
Created attachment 165131 [details] [review]
Bug 36627: Add tests

k-t-d, from /kohadevbox/koha, run:
yarn run cypress run --spec "./t/cypress/integration/ERM/DataProviders_spec.ts"

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>