Summary: | Include fields with non-filing characters removed when indexing | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | Searching - Elasticsearch | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | Pushed to main --- | QA Contact: | Martin Renvoize <martin.renvoize> |
Severity: | normal | ||
Priority: | P5 - low | CC: | dcook, januszop, m.de.rooy, martin.renvoize |
Version: | unspecified | Keywords: | release-notes-needed |
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Attachments: |
Sample record for testing
Bug 36678: Adjust unit tests Bug 36678: Index fields with non-filing characters in both versions Bug 36678: Adjust unit tests Bug 36678: Index fields with non-filing characters in both versions Bug 36678: Adjust unit tests Bug 36678: Index fields with non-filing characters in both versions |
Description
Nick Clemens (kidclamp)
2024-04-23 18:57:15 UTC
Created attachment 165439 [details] [review] Bug 36678: Adjust unit tests Created attachment 165440 [details] [review] Bug 36678: Index fields with non-filing characters in both versions Currently we only remove non-filing characters for sort fields, however, this can make searching difficult. This patch adds the filing form to the index as well to aid in searching. To test: 0 - Setup Koha with Elasticsearch 1 - Import the sample record on this report: "L'amour de l'art" 2 - Search for "amour de l'art" - no results 3 - Apply patch 4 - Reindex 5 - Search for "amour de l'art" - result! 6 - Search for "title:amour de l'art" - result! Created attachment 165648 [details] [review] Bug 36678: Adjust unit tests Signed-off-by: David Nind <david@davidnind.com> Created attachment 165649 [details] [review] Bug 36678: Index fields with non-filing characters in both versions Currently we only remove non-filing characters for sort fields, however, this can make searching difficult. This patch adds the filing form to the index as well to aid in searching. To test: 0 - Setup Koha with Elasticsearch 1 - Import the sample record on this report: "L'amour de l'art" 2 - Search for "amour de l'art" - no results 3 - Apply patch 4 - Reindex 5 - Search for "amour de l'art" - result! 6 - Search for "title:amour de l'art" - result! Signed-off-by: David Nind <david@davidnind.com> Created attachment 165960 [details] [review] Bug 36678: Adjust unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 165961 [details] [review] Bug 36678: Index fields with non-filing characters in both versions Currently we only remove non-filing characters for sort fields, however, this can make searching difficult. This patch adds the filing form to the index as well to aid in searching. To test: 0 - Setup Koha with Elasticsearch 1 - Import the sample record on this report: "L'amour de l'art" 2 - Search for "amour de l'art" - no results 3 - Apply patch 4 - Reindex 5 - Search for "amour de l'art" - result! 6 - Search for "title:amour de l'art" - result! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Nice improvement, covered by tests, works as described and QA scripts happy. Passing QA Pushed for 24.05! Well done everyone, thank you! |