Created attachment 165438 [details] Sample record for testing Currently we only remove non-filing characters for sort fields, however, this can make searching difficult. Consider: L'amour de l'art : art contemporain et collections privées du Sud-Ouest. Currently a search for: amour de l'art will return no results in elastic search We should include the form with non-filing characters removed See also bug 21357
Created attachment 165439 [details] [review] Bug 36678: Adjust unit tests
Created attachment 165440 [details] [review] Bug 36678: Index fields with non-filing characters in both versions Currently we only remove non-filing characters for sort fields, however, this can make searching difficult. This patch adds the filing form to the index as well to aid in searching. To test: 0 - Setup Koha with Elasticsearch 1 - Import the sample record on this report: "L'amour de l'art" 2 - Search for "amour de l'art" - no results 3 - Apply patch 4 - Reindex 5 - Search for "amour de l'art" - result! 6 - Search for "title:amour de l'art" - result!
Created attachment 165648 [details] [review] Bug 36678: Adjust unit tests Signed-off-by: David Nind <david@davidnind.com>
Created attachment 165649 [details] [review] Bug 36678: Index fields with non-filing characters in both versions Currently we only remove non-filing characters for sort fields, however, this can make searching difficult. This patch adds the filing form to the index as well to aid in searching. To test: 0 - Setup Koha with Elasticsearch 1 - Import the sample record on this report: "L'amour de l'art" 2 - Search for "amour de l'art" - no results 3 - Apply patch 4 - Reindex 5 - Search for "amour de l'art" - result! 6 - Search for "title:amour de l'art" - result! Signed-off-by: David Nind <david@davidnind.com>
Created attachment 165960 [details] [review] Bug 36678: Adjust unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 165961 [details] [review] Bug 36678: Index fields with non-filing characters in both versions Currently we only remove non-filing characters for sort fields, however, this can make searching difficult. This patch adds the filing form to the index as well to aid in searching. To test: 0 - Setup Koha with Elasticsearch 1 - Import the sample record on this report: "L'amour de l'art" 2 - Search for "amour de l'art" - no results 3 - Apply patch 4 - Reindex 5 - Search for "amour de l'art" - result! 6 - Search for "title:amour de l'art" - result! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Nice improvement, covered by tests, works as described and QA scripts happy. Passing QA
Pushed for 24.05! Well done everyone, thank you!
Pushed to 23.11.x for 23.11.06
Backported to 23.05.x for upcoming 23.05.12