Summary: | Unable to delete a budget | ||
---|---|---|---|
Product: | Koha | Reporter: | Caroline Cyr La Rose <caroline.cyr-la-rose> |
Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 36739: Correct CSRF change to budget deletions
Bug 36739: Correct CSRF change to budget deletions Bug 36739: Correct CSRF change to budget deletions |
Description
Caroline Cyr La Rose
2024-04-30 21:17:58 UTC
I noticed the budget name is not in the warning message in step 7, but the budget_period_id is in the URL, so I'm not sure what is happening. Created attachment 165957 [details] [review] Bug 36739: Correct CSRF change to budget deletions This is another instance of the deletion confirmation step getting mistakenly auto-updated as if it were the deletion step. The 'delete_confirm' doesn't need the 'cud-' prefix, only the 'delete_confirmed' step. To test, apply the patch and restart services. - Test the process of deleting a budget. - On the confirmation step you should see the name of the budget you're about to delete. - After confirming, the deletion should complete correctly. Created attachment 165966 [details] [review] Bug 36739: Correct CSRF change to budget deletions This is another instance of the deletion confirmation step getting mistakenly auto-updated as if it were the deletion step. The 'delete_confirm' doesn't need the 'cud-' prefix, only the 'delete_confirmed' step. To test, apply the patch and restart services. - Test the process of deleting a budget. - On the confirmation step you should see the name of the budget you're about to delete. - After confirming, the deletion should complete correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Thanks Owen! Created attachment 166879 [details] [review] Bug 36739: Correct CSRF change to budget deletions This is another instance of the deletion confirmation step getting mistakenly auto-updated as if it were the deletion step. The 'delete_confirm' doesn't need the 'cud-' prefix, only the 'delete_confirmed' step. To test, apply the patch and restart services. - Test the process of deleting a budget. - On the confirmation step you should see the name of the budget you're about to delete. - After confirming, the deletion should complete correctly. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.05! Well done everyone, thank you! Not for 23.11.x Bug fix, nothing to add/edit in the Koha manual. |