| Summary: | Remove TODO about missing summary info in the SIP2 code | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | SIP2 | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | Pushed to main --- | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | bibliothek |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26586 | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
26.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 36752: Remove confusing TODOs
Bug 36752: Remove confusing TODOs |
||
|
Description
Marcel de Rooy
2024-05-02 11:32:59 UTC
(In reply to Marcel de Rooy from comment #0) > If you set Y (at the right position) in the 63 summary request, the 64 > should contain "charged items", i.e. the items that you have on loan. > > The code for handle_patron_info just contains a TODO here :) Can you still confirm the issue? I checked on main via summary ' Y' (charged items) perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 -m patron_information -s ' Y ' ... SEND: 6300120260217 114817 Y AOCPL|AA23529000035676|ACterm1| READ: 64 00120260217 114817000000000002000000000000AOCPL|AA23529000035676|AEHenry Acevedo|BLY|BHUSD|BV0|CC5|AU39999000006117|AU39999000006094|BD4345 Library Rd. Springfield, MA 44224|BF(212) 555-1212|PB19580530|PCS|PIY|AFGreetings from Koha. | The response included the items in repeating AU fields (In reply to Jan Kissig from comment #1) > (In reply to Marcel de Rooy from comment #0) > > If you set Y (at the right position) in the 63 summary request, the 64 > > should contain "charged items", i.e. the items that you have on loan. > > > > The code for handle_patron_info just contains a TODO here :) > > Can you still confirm the issue? > > I checked on main via summary ' Y' (charged items) > > perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l > CPL --patron 23529000035676 -m patron_information -s ' Y ' > ... > SEND: 6300120260217 114817 Y AOCPL|AA23529000035676|ACterm1| > READ: 64 00120260217 > 114817000000000002000000000000AOCPL|AA23529000035676|AEHenry > Acevedo|BLY|BHUSD|BV0|CC5|AU39999000006117|AU39999000006094|BD4345 Library > Rd. Springfield, MA 44224|BF(212) 555-1212|PB19580530|PCS|PIY|AFGreetings > from Koha. | > > The response included the items in repeating AU fields Ah. Thanks. You are right. They are included via summary_info. Will remove the misleading TODOs in the code. Created attachment 193506 [details] [review] Bug 36752: Remove confusing TODOs As Jan Kissig correctly mentioned on the BZ report, the various summary info on charged items etc. are included. This is done via the summary_info sub. Note that the TODOs about BZ FID_HOLD_ITEMS_LMT CA FID_OVERDUE_ITEMS_LMT CB FID_CHARGED_ITEMS_LMT are still valid. This is not included yet. Test plan. Since we are just removing comments, read the code. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Trivial change (comments only). Self SO Created attachment 193542 [details] [review] Bug 36752: Remove confusing TODOs As Jan Kissig correctly mentioned on the BZ report, the various summary info on charged items etc. are included. This is done via the summary_info sub. Note that the TODOs about BZ FID_HOLD_ITEMS_LMT CA FID_OVERDUE_ITEMS_LMT CB FID_CHARGED_ITEMS_LMT are still valid. This is not included yet. Test plan. Since we are just removing comments, read the code. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Nice work everyone! Pushed to main for 26.05 |