Bug 26586 - Koha should return a SIP2 64 response to a 63 request for fee items
Summary: Koha should return a SIP2 64 response to a 63 request for fee items
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: SIP2 (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-10-01 00:00 UTC by David Cook
Modified: 2024-11-13 19:06 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
SIP2 Protocol Extensions (185.00 KB, application/msword)
2020-10-01 00:08 UTC, David Cook 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2020-10-01 00:00:38 UTC 
At the moment, we're supporting SIP 2.0 for the 63 Patron Information Request, but the 3M SIP2 Protocol Extensions outlines a 7th position "fee items".

If a SIP2 client sents a Y in that position, Koha will close the connection.

At the very least, it should just return a 64 response and just not send any fee item info back.
Comment 1 David Cook 2020-10-01 00:08:01 UTC 
Created attachment 111011 [details]
SIP2 Protocol Extensions
Comment 2 David Cook 2020-10-01 02:32:00 UTC 
After a bit more review, it looks like Koha is silently getting a fatal error, and then closes the connection.

While we don't need to support the SIP2 Protocol Extension, I think we should continue to work. Looking at the SIP2 server code, it's just badly written code, which makes too many assumptions.
Comment 3 Katrin Fischer 2024-11-13 19:06:20 UTC 
Is this a duplicate of bug 36752?