Summary: | Increase length of 'code' column in borrower_attribute_types | ||
---|---|---|---|
Product: | Koha | Reporter: | Pedro Amorim <pedro.amorim> |
Component: | Database | Assignee: | Pedro Amorim <pedro.amorim> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, fridolin.somers, kyle, m.de.rooy, martin.renvoize |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/899 |
Text to go in the release notes: |
This extends the borrower_attribute_types.code field from varchar(10) to varchar(64). This makes it easier to use also for plugins who might want to use unique prefixes.
|
Version(s) released in: |
24.05.00
|
Circulation function: | |||
Attachments: |
Bug 36755: Update UI input element
Bug 36755: Atomicupdate file Bug 36755: Atomicupdate file Bug 36755: Update UI input element Bug 36755: Atomicupdate file Bug 36755: Update UI input element Bug 36755: Atomicupdate file Bug 36755: Update kohastructure.sql Bug 36755: Update UI input element Bug 36755: Atomicupdate file Bug 36755: Update kohastructure.sql |
Description
Pedro Amorim
2024-05-02 12:40:30 UTC
Created attachment 166070 [details] [review] Bug 36755: Update UI input element Created attachment 166071 [details] [review] Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Created attachment 166086 [details] [review] Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Signed-off-by: David Nind <david@davidnind.com> Created attachment 166087 [details] [review] Bug 36755: Update UI input element Signed-off-by: David Nind <david@davidnind.com> Created attachment 166088 [details] [review] Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Signed-off-by: David Nind <david@davidnind.com> Missing updates to kohastructure.sql Created attachment 166309 [details] [review] Bug 36755: Update UI input element Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 166310 [details] [review] Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 166311 [details] [review] Bug 36755: Update kohastructure.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (In reply to Kyle M Hall from comment #9) > Created attachment 166311 [details] [review] [review] > Bug 36755: Update kohastructure.sql > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Doh. Thanks! I got so enveloped in the rabbit hole of atomic update I forgot kohastructure.sql. Although your follow-up seems to be missing the code column update on borrower_attribute_types! (In reply to Pedro Amorim from comment #10) > (In reply to Kyle M Hall from comment #9) > > Created attachment 166311 [details] [review] [review] [review] > > Bug 36755: Update kohastructure.sql > > > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > > Doh. Thanks! I got so enveloped in the rabbit hole of atomic update I forgot > kohastructure.sql. > > Although your follow-up seems to be missing the code column update on > borrower_attribute_types! Can you please add it? Created attachment 166351 [details] [review] Bug 36755: Update UI input element Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 166352 [details] [review] Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Created attachment 166353 [details] [review] Bug 36755: Update kohastructure.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> PA amended: Squashed borrower_attribute_types table update Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Pushed for 24.05! Well done everyone, thank you! (In reply to Pedro Amorim from comment #10) > (In reply to Kyle M Hall from comment #9) > > Created attachment 166311 [details] [review] [review] [review] > > Bug 36755: Update kohastructure.sql > > > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > > Doh. Thanks! I got so enveloped in the rabbit hole of atomic update I forgot > kohastructure.sql. > > Although your follow-up seems to be missing the code column update on > borrower_attribute_types! Thanks Pedro! Looks like I forgot the DBIC update, will push this to main now. Not backported to 23.11.x |