Plugins may want to make use of patron attribute types thus prepending some data to the code of a patron attribute type they may need could be useful e.g. kitchensink_somefield. Currently, the 'code' is limited to VARCHAR(10) so this not possible.
Created attachment 166070 [details] [review] Bug 36755: Update UI input element
Created attachment 166071 [details] [review] Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64)
Created attachment 166086 [details] [review] Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 166087 [details] [review] Bug 36755: Update UI input element Signed-off-by: David Nind <david@davidnind.com>
Created attachment 166088 [details] [review] Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Signed-off-by: David Nind <david@davidnind.com>
Missing updates to kohastructure.sql
Created attachment 166309 [details] [review] Bug 36755: Update UI input element Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 166310 [details] [review] Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 166311 [details] [review] Bug 36755: Update kohastructure.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(In reply to Kyle M Hall from comment #9) > Created attachment 166311 [details] [review] [review] > Bug 36755: Update kohastructure.sql > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Doh. Thanks! I got so enveloped in the rabbit hole of atomic update I forgot kohastructure.sql. Although your follow-up seems to be missing the code column update on borrower_attribute_types!
(In reply to Pedro Amorim from comment #10) > (In reply to Kyle M Hall from comment #9) > > Created attachment 166311 [details] [review] [review] [review] > > Bug 36755: Update kohastructure.sql > > > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > > Doh. Thanks! I got so enveloped in the rabbit hole of atomic update I forgot > kohastructure.sql. > > Although your follow-up seems to be missing the code column update on > borrower_attribute_types! Can you please add it?
Created attachment 166351 [details] [review] Bug 36755: Update UI input element Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 166352 [details] [review] Bug 36755: Atomicupdate file Test plan, k-t-d: 1) Apply patches. 2) Run the following SQL and save the output of each: SHOW CREATE TABLE pseudonymized_borrower_attributes; SHOW CREATE TABLE borrower_attribute_types_branches; SHOW CREATE TABLE borrower_attributes; SHOW CREATE TABLE borrower_attribute_types; 3) Run updatedatabase 4) Run the SQL queries again, compare the output of each with the previous output before updatedatabase. 5) Make sure the only diff between the two is VARCHAR(10) -> VARCHAR(64) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 166353 [details] [review] Bug 36755: Update kohastructure.sql Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> PA amended: Squashed borrower_attribute_types table update Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Pushed for 24.05! Well done everyone, thank you!
(In reply to Pedro Amorim from comment #10) > (In reply to Kyle M Hall from comment #9) > > Created attachment 166311 [details] [review] [review] [review] > > Bug 36755: Update kohastructure.sql > > > > Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> > > Doh. Thanks! I got so enveloped in the rabbit hole of atomic update I forgot > kohastructure.sql. > > Although your follow-up seems to be missing the code column update on > borrower_attribute_types! Thanks Pedro!
Looks like I forgot the DBIC update, will push this to main now.
Not backported to 23.11.x