| Summary: | New order from existing bibliographic record does not show MARC subfield name | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Acquisitions | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | lucas, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.05.00,23.11.06,23.05.12
|
|
| Circulation function: | |||
| Bug Depends on: | 19289 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 36856: Fix marc subfield name in new order from existing biblio
Bug 36856: Fix marc subfield name in new order from existing biblio Bug 36856: Fix marc subfield name in new order from existing biblio |
||
|
Description
Fridolin Somers
2024-05-14 09:30:05 UTC
(In reply to Fridolin Somers from comment #0) > In form of the bibliographic details when adding an order 'From a new > (empty) record' in a basket, the marc subfield name is not shown. > The template calls [% field.lib | html %] but this comes from > Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives > 'marc_lib'. Oups => adding an order 'From an existing record' Created attachment 166681 [details] [review] Bug 36856: Fix marc subfield name in new order from existing biblio In form of the bibliographic details when adding an order 'From an existing record' in a basket, the marc subfield name is not shown. The template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'. Test plan: 1) Be sure to have an ACQ biblio framework 2) Enable system preference UseACQFrameworkForBiblioRecords 3) Go to an acquisition basket 4) Add a term in 'From an existing record' and submit 5) On first result click on 'Add order' 6) Look at 'Catalog details' => Without patch you only see subfield tag and letter : (123a) => With patch you also see subfield name : Name (123a) Created attachment 166692 [details] [review] Bug 36856: Fix marc subfield name in new order from existing biblio In form of the bibliographic details when adding an order 'From an existing record' in a basket, the marc subfield name is not shown. The template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'. Test plan: 1) Be sure to have an ACQ biblio framework 2) Enable system preference UseACQFrameworkForBiblioRecords 3) Go to an acquisition basket 4) Add a term in 'From an existing record' and submit 5) On first result click on 'Add order' 6) Look at 'Catalog details' => Without patch you only see subfield tag and letter : (123a) => With patch you also see subfield name : Name (123a) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Created attachment 166913 [details] [review] Bug 36856: Fix marc subfield name in new order from existing biblio In form of the bibliographic details when adding an order 'From an existing record' in a basket, the marc subfield name is not shown. The template calls [% field.lib | html %] but this comes from Koha::UI::Form::Builder::Biblio generate_subfield_form() which gives 'marc_lib'. Test plan: 1) Be sure to have an ACQ biblio framework 2) Enable system preference UseACQFrameworkForBiblioRecords 3) Go to an acquisition basket 4) Add a term in 'From an existing record' and submit 5) On first result click on 'Add order' 6) Look at 'Catalog details' => Without patch you only see subfield tag and letter : (123a) => With patch you also see subfield name : Name (123a) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> No string change, small template change. Pushed for 24.05! Well done everyone, thank you! Pushed to 23.11.x for 23.11.06 Backported to 23.05.x for upcoming 23.05.12 Not backporting to 22.11 |