Summary: | In table settings words are split in two and some of them cannot be translated properly | ||
---|---|---|---|
Product: | Koha | Reporter: | Anneli Österman <anneli.osterman> |
Component: | I18N/L10N | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | f.demians, fridolin.somers, jonathan.druart, m.de.rooy |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
24.05.00
|
|
Circulation function: | |||
Bug Depends on: | 35883 | ||
Bug Blocks: | |||
Attachments: |
Bug 36876: Correct <span>s around translatable strings in table settings
Bug 36876: Correct <span>s around translatable strings in table settings Bug 36876: Correct <span>s around translatable strings in table settings |
Description
Anneli Österman
2024-05-16 06:21:20 UTC
That's been some really good detective work, Anneli! I hope we can have a fix before the end of the week (similar issues for German). Created attachment 166820 [details] [review] Bug 36876: Correct <span>s around translatable strings in table settings This patch corrects the way translatable strings are handled in the table settings template. The switch to Bootstrap WRAPPERs for the accordion widget included several errors. To test, apply the patch and go to Administration -> Table settings. - Confirm that the sections expand and collapse correctly. - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:298 - It should show the whole string "Interlibrary loans" Created attachment 166839 [details] [review] Bug 36876: Correct <span>s around translatable strings in table settings This patch corrects the way translatable strings are handled in the table settings template. The switch to Bootstrap WRAPPERs for the accordion widget included several errors. To test, apply the patch and go to Administration -> Table settings. - Confirm that the sections expand and collapse correctly. - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:298 - It should show the whole string "Interlibrary loans" Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 166880 [details] [review] Bug 36876: Correct <span>s around translatable strings in table settings This patch corrects the way translatable strings are handled in the table settings template. The switch to Bootstrap WRAPPERs for the accordion widget included several errors. To test, apply the patch and go to Administration -> Table settings. - Confirm that the sections expand and collapse correctly. - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:298 - It should show the whole string "Interlibrary loans" Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed for 24.05! Well done everyone, thank you! |