I'm translating the main into Finnish and there are new translations for Table settings. The two word headings have been for some reason split into two different strings. One of them can still be translated but for example word "Interlibrary loans" is one word in Finnish, "Kaukolainat", and is hard to split in two. You'd have to put the whole word into the first string and leave the other one empty. https://translate.koha-community.org/translate/koha/main/staff-prog/fi/?checksum=7f3536ca451413ca %s %s %s %s %s Interlibrary https://translate.koha-community.org/translate/koha/main/staff-prog/fi/?checksum=b87bf29db072c461 loans It comes from here https://github.com/Koha-Community/Koha/blob/main/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt#L296C1-L299C46 [% WRAPPER accordion_item %] [% WRAPPER accordion_heading panel_id="illrequests" %] Interlibrary <span>loans</span> [% END %] Others that have been split too: [% WRAPPER accordion_item %] [% WRAPPER accordion_heading panel_id="coursereserves" %] Course <span>reserves</span> [% END %] In Finnish: Kurssivarannot [% WRAPPER accordion_item %] [% WRAPPER accordion_heading panel_id="pos" %] Point of <span>sale</span> [% END %] In Finnish: Myyntipiste [% WRAPPER accordion_item %] [% WRAPPER accordion_heading panel_id="erm" %] E-resource <span>management</span> [% END %] In Finnish: E-ainestojen hallinta Could these strings be unsplit?
That's been some really good detective work, Anneli! I hope we can have a fix before the end of the week (similar issues for German).
Created attachment 166820 [details] [review] Bug 36876: Correct <span>s around translatable strings in table settings This patch corrects the way translatable strings are handled in the table settings template. The switch to Bootstrap WRAPPERs for the accordion widget included several errors. To test, apply the patch and go to Administration -> Table settings. - Confirm that the sections expand and collapse correctly. - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:298 - It should show the whole string "Interlibrary loans"
Created attachment 166839 [details] [review] Bug 36876: Correct <span>s around translatable strings in table settings This patch corrects the way translatable strings are handled in the table settings template. The switch to Bootstrap WRAPPERs for the accordion widget included several errors. To test, apply the patch and go to Administration -> Table settings. - Confirm that the sections expand and collapse correctly. - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:298 - It should show the whole string "Interlibrary loans" Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 166880 [details] [review] Bug 36876: Correct <span>s around translatable strings in table settings This patch corrects the way translatable strings are handled in the table settings template. The switch to Bootstrap WRAPPERs for the accordion widget included several errors. To test, apply the patch and go to Administration -> Table settings. - Confirm that the sections expand and collapse correctly. - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:298 - It should show the whole string "Interlibrary loans" Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed for 24.05! Well done everyone, thank you!
Bug 35883 not in 23.11.x