Bug 36882

Summary: Flatpickr doesn't work for repeatable date patron attributes in overdues
Product: Koha Reporter: Pedro Amorim <pedro.amorim>
Component: PatronsAssignee: Pedro Amorim <pedro.amorim>
Status: Needs documenting --- QA Contact: Marcel de Rooy <m.de.rooy>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, gmcharlt, kyle.m.hall, lucas, m.de.rooy, shi-yao.wang
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04
Circulation function:
Bug Depends on: 32610    
Bug Blocks:    
Attachments: Bug 36882: Reapply flatpickr to cloned entry
Bug 36882: Reapply flatpickr to cloned entry
Bug 36882: Reapply flatpickr to cloned entry

Description Pedro Amorim 2024-05-16 11:43:51 UTC

    
Comment 1 Pedro Amorim 2024-05-16 11:48:11 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2024-05-17 16:46:37 UTC
Created attachment 166915 [details] [review]
Bug 36882: Reapply flatpickr to cloned entry

1) Add a patron attribute type:
   http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type
2) Make sure its repeatable + is_date
3) Visit overdues:
   http://localhost:8081/cgi-bin/koha/circ/overdue.pl
4) Click the 'add' button under the date custom attribute
5) Click on the newly created input, notice the flatpickr pop up doesnt
   show
6) Apply patch. Repeat.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2024-08-16 09:08:35 UTC
Created attachment 170446 [details] [review]
Bug 36882: Reapply flatpickr to cloned entry

1) Add a patron attribute type:
   http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type
2) Make sure its repeatable + is_date
3) Visit overdues:
   http://localhost:8081/cgi-bin/koha/circ/overdue.pl
4) Click the 'add' button under the date custom attribute
5) Click on the newly created input, notice the flatpickr pop up doesnt
   show
6) Apply patch. Repeat.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-08-19 15:31:04 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass (lukeg) 2024-09-12 22:04:20 UTC
Backported to 24.05.x for upcoming 24.05.04
Comment 6 Fridolin Somers 2024-10-21 12:26:29 UTC
Depends on Bug 32610 not in 23.11.x