Bug 36882 - Flatpickr doesn't work for repeatable date patron attributes in overdues
Summary: Flatpickr doesn't work for repeatable date patron attributes in overdues
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Pedro Amorim
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 32610
Blocks:
  Show dependency treegraph
 
Reported: 2024-05-16 11:43 UTC by Pedro Amorim
Modified: 2024-08-19 15:31 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 36882: Reapply flatpickr to cloned entry (1.45 KB, patch)
2024-05-16 11:48 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36882: Reapply flatpickr to cloned entry (1.51 KB, patch)
2024-05-17 16:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 36882: Reapply flatpickr to cloned entry (1.60 KB, patch)
2024-08-16 09:08 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-05-16 11:43:51 UTC

    
Comment 1 Pedro Amorim 2024-05-16 11:48:11 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2024-05-17 16:46:37 UTC
Created attachment 166915 [details] [review]
Bug 36882: Reapply flatpickr to cloned entry

1) Add a patron attribute type:
   http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type
2) Make sure its repeatable + is_date
3) Visit overdues:
   http://localhost:8081/cgi-bin/koha/circ/overdue.pl
4) Click the 'add' button under the date custom attribute
5) Click on the newly created input, notice the flatpickr pop up doesnt
   show
6) Apply patch. Repeat.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2024-08-16 09:08:35 UTC
Created attachment 170446 [details] [review]
Bug 36882: Reapply flatpickr to cloned entry

1) Add a patron attribute type:
   http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type
2) Make sure its repeatable + is_date
3) Visit overdues:
   http://localhost:8081/cgi-bin/koha/circ/overdue.pl
4) Click the 'add' button under the date custom attribute
5) Click on the newly created input, notice the flatpickr pop up doesnt
   show
6) Apply patch. Repeat.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Katrin Fischer 2024-08-19 15:31:04 UTC
Pushed for 24.11!

Well done everyone, thank you!