| Summary: | Missing tooltip on budget planning page | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | Pushed to oldstable --- | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, lucas, m.de.rooy, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the "Budget locked" tooltip for budget fund planning pages (Administration > Budgets > select a budget that is locked > Funds > Planning > any planning option). The tooltip was not styled correctly for fund names - it now has white text on a black background.
|
Version(s) released in: |
24.11.00,24.05.04,23.11.09
|
| Circulation function: | |||
| Bug Depends on: | 34404 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 36885: Fix Bootstrap tooltip on budget planning page
Bug 36885: Fix Bootstrap tooltip on budget planning page Bug 36885: (follow-up) Correct popup hint Bug 36885: (follow-up) Remove tooltip from unlocked budgets (copy-paste error) Bug 36885: Fix Bootstrap tooltip on budget planning page |
||
|
Description
Owen Leonard
2024-05-16 13:55:44 UTC
Created attachment 166831 [details] [review] Bug 36885: Fix Bootstrap tooltip on budget planning page This patch finishes the process of adding a Bootstrap tooltip to the listing of funds which are locked. To test, apply the patch and go to Administration -> Budgets. - Edit a budget and make it locked: Check the "Lock budget" checkbox and save. - View the budget you locked. - From the toolbar, click Planning -> Plan by months. - In the table of funds, hover your mouse over a fund. - You should see a Bootstrap-styled tooltip, "Fund locked." It's a bug in that the feature is half-implemented, an enhancement in that nothing is broken in the current state. Created attachment 166924 [details] [review] Bug 36885: Fix Bootstrap tooltip on budget planning page This patch finishes the process of adding a Bootstrap tooltip to the listing of funds which are locked. To test, apply the patch and go to Administration -> Budgets. - Edit a budget and make it locked: Check the "Lock budget" checkbox and save. - View the budget you locked. - From the toolbar, click Planning -> Plan by months. - In the table of funds, hover your mouse over a fund. - You should see a Bootstrap-styled tooltip, "Fund locked." Signed-off-by: David Nind <david@davidnind.com> Testing notes: 1. Before the patch, the tooltip has a white background, border, and the text is normal-sized. 2. After the patch, the tooltip text is white text on a black background with rounded corners, with a smaller text size. (That is the only difference I noted). Sorry to be nit-picky... but as we lock on budget level, should this be "budget locked"? Also being nit-picky :) ...That's how it was before my patch! Shouldn't we do what is right? Also it didn't work... ;) Happy to make that little change, mostly checking if I am in the wrong or not. Created attachment 168209 [details] [review] Bug 36885: (follow-up) Correct popup hint Why do we add a tooltip Budget locked in the ELSE part here (when there would be no budget lock) ? Hi Owen, can you please reply to Marcel's question so we can get this moving? :) Created attachment 168997 [details] [review] Bug 36885: (follow-up) Remove tooltip from unlocked budgets (copy-paste error) Created attachment 169186 [details] [review] Bug 36885: Fix Bootstrap tooltip on budget planning page This patch finishes the process of adding a Bootstrap tooltip to the listing of funds which are locked. To test, apply the patch and go to Administration -> Budgets. - Edit a budget and make it locked: Check the "Lock budget" checkbox and save. - View the budget you locked. - From the toolbar, click Planning -> Plan by months. - In the table of funds, hover your mouse over a fund. - You should see a Bootstrap-styled tooltip, "Fund locked." Signed-off-by: David Nind <david@davidnind.com> Bug 36885: (follow-up) Correct popup hint Bug 36885: (follow-up) Remove tooltip from unlocked budgets (copy-paste error) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Backported to 24.05.x for upcoming 24.05.04 Pushed to 23.11.x for 23.11.09 Not backporting to 23.05.x unless requested |