Bug 36919

Summary: t/db_dependent/Koha/Object.t produces warnings
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Test SuiteAssignee: Jonathan Druart <jonathan.druart>
Status: Pushed to stable --- QA Contact: Lucas Gass (lukeg) <lucas>
Severity: minor    
Priority: P5 - low CC: lucas
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:
Bug Depends on:    
Bug Blocks: 25515    
Attachments: Bug 36919: Remove a warning from Koha/Object.t
Bug 36919: Remove another warning from Koha/Object.t
Bug 36919: Remove yet another warning from Koha/Object.t
Bug 36919: Remove a warning from Koha/Object.t
Bug 36919: Remove another warning from Koha/Object.t
Bug 36919: Remove yet another warning from Koha/Object.t
Bug 36919: Remove a warning from Koha/Object.t
Bug 36919: Remove another warning from Koha/Object.t
Bug 36919: Remove yet another warning from Koha/Object.t

Description Jonathan Druart 2024-05-22 09:21:41 UTC
t/db_dependent/Koha/Object.t .. 3/22 Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Patron.pm line 446.                                                                                      t/db_dependent/Koha/Object.t .. 8/22 C4::Context->userenv not defined! at /kohadevbox/koha/Koha/Patron.pm line 1890.                                                                                                 
C4::Context->userenv not defined! at /kohadevbox/koha/Koha/Patron.pm line 1890.
t/db_dependent/Koha/Object.t .. 9/22 DBIx::Class::Storage::DBI::insert(): Missing value for primary key column 'currency' on Currency - perhaps you forgot to set its 'is_auto_increment' attribute during add_column
s()? Treating 'currency' implicitly as an autoinc, and attempting value retrieval at /kohadevbox/koha/Koha/Object.pm line 172
t/db_dependent/Koha/Object.t .. ok
Comment 1 Jonathan Druart 2024-05-22 09:24:00 UTC
Created attachment 167014 [details] [review]
Bug 36919: Remove a warning from Koha/Object.t

Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Patron.pm line 446.
Comment 2 Jonathan Druart 2024-05-22 09:24:03 UTC
Created attachment 167015 [details] [review]
Bug 36919: Remove another warning from Koha/Object.t

C4::Context->userenv not defined! at /kohadevbox/koha/Koha/Patron.pm
line 1890.
Comment 3 Jonathan Druart 2024-05-22 09:24:05 UTC
Created attachment 167016 [details] [review]
Bug 36919: Remove yet another warning from Koha/Object.t

DBIx::Class::Storage::DBI::insert(): Missing value for primary key column 'currency' on Currency - perhaps you forgot to set its 'is_auto_increment' attribute during add_columns()? Treating 'currency' implicitly as an autoinc, and attempting value retrieval at /kohadevbox/koha/Koha/Object.pm line 172
Comment 4 David Nind 2024-05-23 04:16:10 UTC
Created attachment 167057 [details] [review]
Bug 36919: Remove a warning from Koha/Object.t

Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Patron.pm line 446.

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2024-05-23 04:16:12 UTC
Created attachment 167058 [details] [review]
Bug 36919: Remove another warning from Koha/Object.t

C4::Context->userenv not defined! at /kohadevbox/koha/Koha/Patron.pm
line 1890.

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2024-05-23 04:16:14 UTC
Created attachment 167059 [details] [review]
Bug 36919: Remove yet another warning from Koha/Object.t

DBIx::Class::Storage::DBI::insert(): Missing value for primary key column 'currency' on Currency - perhaps you forgot to set its 'is_auto_increment' attribute during add_columns()? Treating 'currency' implicitly as an autoinc, and attempting value retrieval at /kohadevbox/koha/Koha/Object.pm line 172
Signed-off-by: David Nind <david@davidnind.com>
Comment 7 Lucas Gass (lukeg) 2024-08-27 16:40:58 UTC
Created attachment 170777 [details] [review]
Bug 36919: Remove a warning from Koha/Object.t

Use of uninitialized value in numeric eq (==) at /kohadevbox/koha/Koha/Patron.pm line 446.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Lucas Gass (lukeg) 2024-08-27 16:41:01 UTC
Created attachment 170778 [details] [review]
Bug 36919: Remove another warning from Koha/Object.t

C4::Context->userenv not defined! at /kohadevbox/koha/Koha/Patron.pm
line 1890.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 9 Lucas Gass (lukeg) 2024-08-27 16:41:04 UTC
Created attachment 170779 [details] [review]
Bug 36919: Remove yet another warning from Koha/Object.t

DBIx::Class::Storage::DBI::insert(): Missing value for primary key column 'currency' on Currency - perhaps you forgot to set its 'is_auto_increment' attribute during add_columns()? Treating 'currency' implicitly as an autoinc, and attempting value retrieval at /kohadevbox/koha/Koha/Object.pm line 172
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 10 Katrin Fischer 2024-08-29 16:16:57 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 11 Lucas Gass (lukeg) 2024-11-15 20:30:05 UTC
Backported to 24.05.x for upcoming 24.05.06