| Summary: | Correct hint on date patron attributes not being repeatable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | System Administration | Assignee: | David Nind <david> |
| Status: | RESOLVED FIXED | QA Contact: | Lucas Gass (lukeg) <lucas> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, pedro.amorim |
| Version: | Main | Keywords: | Academy |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This updates the hint text for "Is a date" when adding a patron attribute - date fields are now repeatable (an enhancement added to Koha 24.05 by bug 32610).
|
Version(s) released in: |
24.11.00,24.05.02
|
| Circulation function: | |||
| Bug Depends on: | 32610 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 36922: Patron attributes - update hint text for "Is a date"
Bug 36922: Patron attributes - update hint text for "Is a date" Bug 36922: Patron attributes - update hint text for "Is a date" |
||
|
Description
Katrin Fischer
2024-05-22 11:21:42 UTC
Created attachment 167319 [details] [review] Bug 36922: Patron attributes - update hint text for "Is a date" The date field for patron attributes is now repeatable (enhancement made in Koha 24.05 with bug 32610). This updates the hint text to reflect the change. Test plan: 1. Go to add a patron attribute (Administration > Patrons and circulation > Patron attribute types > + New patron attribute type ) 2. Note that the hint for the "Is a date" field says "...Date attributes cannot be repeatable or linked to an authorised value category.". 3. Apply the patch. 4. Reload the page. 5. Note that the hint now says "...Date attributes are repeatable, but cannot be linked to an authorised value category." 6. Sign off D: Signed-off-by: David Nind <david@davidnind.com> Created attachment 167337 [details] [review] Bug 36922: Patron attributes - update hint text for "Is a date" The date field for patron attributes is now repeatable (enhancement made in Koha 24.05 with bug 32610). This updates the hint text to reflect the change. Test plan: 1. Go to add a patron attribute (Administration > Patrons and circulation > Patron attribute types > + New patron attribute type ) 2. Note that the hint for the "Is a date" field says "...Date attributes cannot be repeatable or linked to an authorised value category.". 3. Apply the patch. 4. Reload the page. 5. Note that the hint now says "...Date attributes are repeatable, but cannot be linked to an authorised value category." 6. Sign off D: PA amended: 'are repeatable' -> 'can be repeatable' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> @David I changed the text slightly: 'are repeatable' -> 'can be repeatable' Date fields are optionally repeatable, so it may or may not be repeatable. Do you agree with this? Thanks. (In reply to Pedro Amorim from comment #3) > @David I changed the text slightly: > 'are repeatable' -> 'can be repeatable' > > Date fields are optionally repeatable, so it may or may not be repeatable. > Do you agree with this? Thanks. Thanks Pedro. I generally try to write things in the active voice, but I'm OK with the change. David Created attachment 167400 [details] [review] Bug 36922: Patron attributes - update hint text for "Is a date" The date field for patron attributes is now repeatable (enhancement made in Koha 24.05 with bug 32610). This updates the hint text to reflect the change. Test plan: 1. Go to add a patron attribute (Administration > Patrons and circulation > Patron attribute types > + New patron attribute type ) 2. Note that the hint for the "Is a date" field says "...Date attributes cannot be repeatable or linked to an authorised value category.". 3. Apply the patch. 4. Reload the page. 5. Note that the hint now says "...Date attributes are repeatable, but cannot be linked to an authorised value category." 6. Sign off D: PA amended: 'are repeatable' -> 'can be repeatable' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Backported to 24.05.x for upcoming 24.05.02 |