Bug 36922 - Correct hint on date patron attributes not being repeatable
Summary: Correct hint on date patron attributes not being repeatable
Status: Passed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: David Nind
QA Contact: Testopia
URL:
Keywords: Academy
Depends on: 32610
Blocks:
  Show dependency treegraph
 
Reported: 2024-05-22 11:21 UTC by Katrin Fischer
Modified: 2024-06-04 14:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This updates the hint text for "Is a date" when adding a patron attribute - date fields are now repeatable (an enhancement added to Koha 24.05 by bug 32610).
Version(s) released in:


Attachments
Bug 36922: Patron attributes - update hint text for "Is a date" (1.93 KB, patch)
2024-05-31 21:51 UTC, David Nind
Details | Diff | Splinter Review
Bug 36922: Patron attributes - update hint text for "Is a date" (2.04 KB, patch)
2024-06-03 08:39 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 36922: Patron attributes - update hint text for "Is a date" (2.09 KB, patch)
2024-06-04 14:47 UTC, Lucas Gass
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2024-05-22 11:21:42 UTC
Date attributes can now be repeated, so we should update the hint on the administration page:

If checked, attribute will be a date. Date attributes cannot be repeatable or linked to an authorised value category.
Comment 1 David Nind 2024-05-31 21:51:43 UTC
Created attachment 167319 [details] [review]
Bug 36922: Patron attributes - update hint text for "Is a date"

The date field for patron attributes is now repeatable (enhancement made
in Koha 24.05 with bug 32610). This updates the hint text to reflect
the change.

Test plan:
1. Go to add a patron attribute (Administration > Patrons and
   circulation > Patron attribute types > + New patron attribute type )
2. Note that the hint for the "Is a date" field says "...Date attributes
   cannot be repeatable or linked to an authorised value category.".
3. Apply the patch.
4. Reload the page.
5. Note that the hint now says "...Date attributes are repeatable,
   but cannot be linked to an authorised value category."
6. Sign off D:

Signed-off-by: David Nind <david@davidnind.com>
Comment 2 Pedro Amorim 2024-06-03 08:39:58 UTC
Created attachment 167337 [details] [review]
Bug 36922: Patron attributes - update hint text for "Is a date"

The date field for patron attributes is now repeatable (enhancement made
in Koha 24.05 with bug 32610). This updates the hint text to reflect
the change.

Test plan:
1. Go to add a patron attribute (Administration > Patrons and
   circulation > Patron attribute types > + New patron attribute type )
2. Note that the hint for the "Is a date" field says "...Date attributes
   cannot be repeatable or linked to an authorised value category.".
3. Apply the patch.
4. Reload the page.
5. Note that the hint now says "...Date attributes are repeatable,
   but cannot be linked to an authorised value category."
6. Sign off D:

PA amended: 'are repeatable' -> 'can be repeatable'

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 3 Pedro Amorim 2024-06-03 08:42:12 UTC
@David I changed the text slightly:
'are repeatable' -> 'can be repeatable'

Date fields are optionally repeatable, so it may or may not be repeatable.
Do you agree with this? Thanks.
Comment 4 David Nind 2024-06-04 00:01:38 UTC
(In reply to Pedro Amorim from comment #3)
> @David I changed the text slightly:
> 'are repeatable' -> 'can be repeatable'
> 
> Date fields are optionally repeatable, so it may or may not be repeatable.
> Do you agree with this? Thanks.

Thanks Pedro.

I generally try to write things in the active voice, but I'm OK with the change.

David
Comment 5 Lucas Gass 2024-06-04 14:47:54 UTC
Created attachment 167400 [details] [review]
Bug 36922: Patron attributes - update hint text for "Is a date"

The date field for patron attributes is now repeatable (enhancement made
in Koha 24.05 with bug 32610). This updates the hint text to reflect
the change.

Test plan:
1. Go to add a patron attribute (Administration > Patrons and
   circulation > Patron attribute types > + New patron attribute type )
2. Note that the hint for the "Is a date" field says "...Date attributes
   cannot be repeatable or linked to an authorised value category.".
3. Apply the patch.
4. Reload the page.
5. Note that the hint now says "...Date attributes are repeatable,
   but cannot be linked to an authorised value category."
6. Sign off D:

PA amended: 'are repeatable' -> 'can be repeatable'

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>