Bug 36950

Summary: Improve placement of catalog concern banner in the OPAC
Product: Koha Reporter: Owen Leonard <oleonard>
Component: OPACAssignee: Owen Leonard <oleonard>
Status: Pushed to oldstable --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: minor    
Priority: P5 - low CC: fridolin.somers, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:
Attachments: Screenshot of the poorly-placed catalog concern banner
Bug 36950: Improve placement of catalog concern banner in the OPAC
Bug 36950: Improve placement of catalog concern banner in the OPAC
Bug 36950: Improve placement of catalog concern banner in the OPAC

Description Owen Leonard 2024-05-23 15:40:30 UTC
Created attachment 167118 [details]
Screenshot of the poorly-placed catalog concern banner

After submitting a catalog concern the banner obscures any cover image and looks awkward. I think it should be placed right under the breadcrumbs.
Comment 1 Owen Leonard 2024-05-23 15:50:42 UTC
Created attachment 167119 [details] [review]
Bug 36950: Improve placement of catalog concern banner in the OPAC

This patch changes the placement of the catalog concern banner in the
OPAC. Changing the way it is added to the DOM will prevent it from
obscuring content.

To test, apply the patch and clear your browser cache if necessary.

- In the staff interface, make sure the "OpacCatalogConcerns" system
  preference is enabled.
- Locate a bibliographic record and view the detail page.
- Click the "Report a concern" link in the sidebar.
- Submit your concern.
- When the concern is successfully submitted and the modal closes, the
  success banner ("Your concern was successfully submitted.") should
  appear below the breadcrumbs menu and above the biblio view tabs
  ("Normal view, "MARC view", etc.).

Sponsored-By: Athens County Public Libraries
Comment 2 David Nind 2024-05-23 19:59:14 UTC
Created attachment 167128 [details] [review]
Bug 36950: Improve placement of catalog concern banner in the OPAC

This patch changes the placement of the catalog concern banner in the
OPAC. Changing the way it is added to the DOM will prevent it from
obscuring content.

To test, apply the patch and clear your browser cache if necessary.

- In the staff interface, make sure the "OpacCatalogConcerns" system
  preference is enabled.
- Locate a bibliographic record and view the detail page.
- Click the "Report a concern" link in the sidebar.
- Submit your concern.
- When the concern is successfully submitted and the modal closes, the
  success banner ("Your concern was successfully submitted.") should
  appear below the breadcrumbs menu and above the biblio view tabs
  ("Normal view, "MARC view", etc.).

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2024-07-01 15:48:21 UTC
Created attachment 168323 [details] [review]
Bug 36950: Improve placement of catalog concern banner in the OPAC

This patch changes the placement of the catalog concern banner in the
OPAC. Changing the way it is added to the DOM will prevent it from
obscuring content.

To test, apply the patch and clear your browser cache if necessary.

- In the staff interface, make sure the "OpacCatalogConcerns" system
  preference is enabled.
- Locate a bibliographic record and view the detail page.
- Click the "Report a concern" link in the sidebar.
- Submit your concern.
- When the concern is successfully submitted and the modal closes, the
  success banner ("Your concern was successfully submitted.") should
  appear below the breadcrumbs menu and above the biblio view tabs
  ("Normal view, "MARC view", etc.).

Sponsored-By: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2024-07-01 15:48:47 UTC
Thanks Owen, Passing QA
Comment 5 Katrin Fischer 2024-07-01 16:51:33 UTC
Hm sequence... I don't think we have a real standard there. I would have probably put the location after the Home library, instead of having the collection between, but not a blocker for me.
Comment 6 Katrin Fischer 2024-07-01 16:51:51 UTC
(In reply to Katrin Fischer from comment #5)
> Hm sequence... I don't think we have a real standard there. I would have
> probably put the location after the Home library, instead of having the
> collection between, but not a blocker for me.

Wrong bug...
Comment 7 Katrin Fischer 2024-07-01 16:58:37 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 8 Lucas Gass (lukeg) 2024-11-18 17:24:01 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 9 Fridolin Somers 2024-12-02 10:57:37 UTC
Pushed to 23.11.x for 23.11.11