Created attachment 167118 [details] Screenshot of the poorly-placed catalog concern banner After submitting a catalog concern the banner obscures any cover image and looks awkward. I think it should be placed right under the breadcrumbs.
Created attachment 167119 [details] [review] Bug 36950: Improve placement of catalog concern banner in the OPAC This patch changes the placement of the catalog concern banner in the OPAC. Changing the way it is added to the DOM will prevent it from obscuring content. To test, apply the patch and clear your browser cache if necessary. - In the staff interface, make sure the "OpacCatalogConcerns" system preference is enabled. - Locate a bibliographic record and view the detail page. - Click the "Report a concern" link in the sidebar. - Submit your concern. - When the concern is successfully submitted and the modal closes, the success banner ("Your concern was successfully submitted.") should appear below the breadcrumbs menu and above the biblio view tabs ("Normal view, "MARC view", etc.). Sponsored-By: Athens County Public Libraries
Created attachment 167128 [details] [review] Bug 36950: Improve placement of catalog concern banner in the OPAC This patch changes the placement of the catalog concern banner in the OPAC. Changing the way it is added to the DOM will prevent it from obscuring content. To test, apply the patch and clear your browser cache if necessary. - In the staff interface, make sure the "OpacCatalogConcerns" system preference is enabled. - Locate a bibliographic record and view the detail page. - Click the "Report a concern" link in the sidebar. - Submit your concern. - When the concern is successfully submitted and the modal closes, the success banner ("Your concern was successfully submitted.") should appear below the breadcrumbs menu and above the biblio view tabs ("Normal view, "MARC view", etc.). Sponsored-By: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Created attachment 168323 [details] [review] Bug 36950: Improve placement of catalog concern banner in the OPAC This patch changes the placement of the catalog concern banner in the OPAC. Changing the way it is added to the DOM will prevent it from obscuring content. To test, apply the patch and clear your browser cache if necessary. - In the staff interface, make sure the "OpacCatalogConcerns" system preference is enabled. - Locate a bibliographic record and view the detail page. - Click the "Report a concern" link in the sidebar. - Submit your concern. - When the concern is successfully submitted and the modal closes, the success banner ("Your concern was successfully submitted.") should appear below the breadcrumbs menu and above the biblio view tabs ("Normal view, "MARC view", etc.). Sponsored-By: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks Owen, Passing QA
Hm sequence... I don't think we have a real standard there. I would have probably put the location after the Home library, instead of having the collection between, but not a blocker for me.
(In reply to Katrin Fischer from comment #5) > Hm sequence... I don't think we have a real standard there. I would have > probably put the location after the Home library, instead of having the > collection between, but not a blocker for me. Wrong bug...
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11