Bug 36970

Summary: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered in holds queue view
Product: Koha Reporter: Janusz Kaczmarek <januszop>
Component: Hold requestsAssignee: Janusz Kaczmarek <januszop>
Status: RESOLVED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: david, fridolin.somers, gmcharlt, kyle, lucas, mik, wainuiwitikapark
Version: unspecified   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
This fixes the display of barcodes with spaces in the holds queue. Barcodes are now displayed correctly with a space, rather than with '%20'.
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:
Bug Depends on: 34160    
Bug Blocks:    
Attachments: Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered
Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered
Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered

Description Janusz Kaczmarek 2024-05-27 21:35:30 UTC
If a barcode (in rare cases) contains a space, with bug 34160, it is converted into %20 in holds queue view (because of mistakenly applied uri filter).
Comment 1 Janusz Kaczmarek 2024-05-27 21:51:06 UTC
Created attachment 167196 [details] [review]
Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered

If a barcode (in rare cases) contains a space, with bug 34160, it is
converted into %20 in holds queue view (because of mistakenly applied
uri filter).

Nota bene, in parallel lines of view_holdsqueue.tt a right filter is
used for the barcode.

Test plan:
==========
1. Have an item with the barcode containing a space.
2. Make a hold on it, run build_holds_queue.pl
3. Go to Circulation > Holds queue ; select your branch etc.
4. You should see '%20' instead of the space in the barcode.
5. Apply the patch, restart_all.
6. Repeat p. 3.  You should now see the space in the barcode.
Comment 2 David Nind 2024-05-27 22:55:49 UTC
Created attachment 167197 [details] [review]
Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered

If a barcode (in rare cases) contains a space, with bug 34160, it is
converted into %20 in holds queue view (because of mistakenly applied
uri filter).

Nota bene, in parallel lines of view_holdsqueue.tt a right filter is
used for the barcode.

Test plan:
==========
1. Have an item with the barcode containing a space.
2. Make a hold on it, run build_holds_queue.pl
3. Go to Circulation > Holds queue ; select your branch etc.
4. You should see '%20' instead of the space in the barcode.
5. Apply the patch, restart_all.
6. Repeat p. 3.  You should now see the space in the barcode.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-05-27 23:04:41 UTC
Testing notes (using KTD):

1. Running the holds queue builder: misc/cronjobs/holds/build_holds_queue.pl
Comment 4 Nick Clemens (kidclamp) 2024-06-26 00:45:11 UTC
Created attachment 168113 [details] [review]
Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered

If a barcode (in rare cases) contains a space, with bug 34160, it is
converted into %20 in holds queue view (because of mistakenly applied
uri filter).

Nota bene, in parallel lines of view_holdsqueue.tt a right filter is
used for the barcode.

Test plan:
==========
1. Have an item with the barcode containing a space.
2. Make a hold on it, run build_holds_queue.pl
3. Go to Circulation > Holds queue ; select your branch etc.
4. You should see '%20' instead of the space in the barcode.
5. Apply the patch, restart_all.
6. Repeat p. 3.  You should now see the space in the barcode.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Katrin Fischer 2024-06-27 09:52:44 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Phil Ringnalda 2024-09-05 17:05:13 UTC
*** Bug 37847 has been marked as a duplicate of this bug. ***
Comment 7 Lucas Gass (lukeg) 2024-11-18 16:49:24 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 8 Fridolin Somers 2024-12-02 09:42:44 UTC
Pushed to 23.11.x for 23.11.11

<< The road to hell is paved with encoding issues >> ^^
Comment 9 Wainui Witika-Park 2025-06-23 03:57:32 UTC
Not backporting to 22.11