Summary: | (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered in holds queue view | ||
---|---|---|---|
Product: | Koha | Reporter: | Janusz Kaczmarek <januszop> |
Component: | Hold requests | Assignee: | Janusz Kaczmarek <januszop> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | david, fridolin.somers, gmcharlt, kyle, lucas, mik, wainuiwitikapark |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the display of barcodes with spaces in the holds queue. Barcodes are now displayed correctly with a space, rather than with '%20'.
|
|
Version(s) released in: |
24.11.00,24.05.06,23.11.11
|
Circulation function: | |
Bug Depends on: | 34160 | ||
Bug Blocks: | |||
Attachments: |
Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered
Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered |
Description
Janusz Kaczmarek
2024-05-27 21:35:30 UTC
Created attachment 167196 [details] [review] Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered If a barcode (in rare cases) contains a space, with bug 34160, it is converted into %20 in holds queue view (because of mistakenly applied uri filter). Nota bene, in parallel lines of view_holdsqueue.tt a right filter is used for the barcode. Test plan: ========== 1. Have an item with the barcode containing a space. 2. Make a hold on it, run build_holds_queue.pl 3. Go to Circulation > Holds queue ; select your branch etc. 4. You should see '%20' instead of the space in the barcode. 5. Apply the patch, restart_all. 6. Repeat p. 3. You should now see the space in the barcode. Created attachment 167197 [details] [review] Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered If a barcode (in rare cases) contains a space, with bug 34160, it is converted into %20 in holds queue view (because of mistakenly applied uri filter). Nota bene, in parallel lines of view_holdsqueue.tt a right filter is used for the barcode. Test plan: ========== 1. Have an item with the barcode containing a space. 2. Make a hold on it, run build_holds_queue.pl 3. Go to Circulation > Holds queue ; select your branch etc. 4. You should see '%20' instead of the space in the barcode. 5. Apply the patch, restart_all. 6. Repeat p. 3. You should now see the space in the barcode. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Running the holds queue builder: misc/cronjobs/holds/build_holds_queue.pl Created attachment 168113 [details] [review] Bug 36970: (Bug 34160 follow-up) Barcode should be html filtered, not uri filtered If a barcode (in rare cases) contains a space, with bug 34160, it is converted into %20 in holds queue view (because of mistakenly applied uri filter). Nota bene, in parallel lines of view_holdsqueue.tt a right filter is used for the barcode. Test plan: ========== 1. Have an item with the barcode containing a space. 2. Make a hold on it, run build_holds_queue.pl 3. Go to Circulation > Holds queue ; select your branch etc. 4. You should see '%20' instead of the space in the barcode. 5. Apply the patch, restart_all. 6. Repeat p. 3. You should now see the space in the barcode. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! *** Bug 37847 has been marked as a duplicate of this bug. *** Backported to 24.05.x for upcoming 24.05.06 Pushed to 23.11.x for 23.11.11 << The road to hell is paved with encoding issues >> ^^ Not backporting to 22.11 |