Summary: | Can't delete library EAN | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Acquisitions | Assignee: | Owen Leonard <oleonard> |
Status: | RESOLVED FIXED | QA Contact: | Martin Renvoize (ashimema) <martin.renvoize> |
Severity: | major | ||
Priority: | P5 - low | CC: | caroline.cyr-la-rose, david, fridolin.somers, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the Library EANs page so that EANs can be deleted. After the CSRF update in 24.05 (bug 34478), the 'Delete' action for an EAN no longer worked as it should.
|
Version(s) released in: |
24.11.00,24.05.02
|
Circulation function: | |||
Bug Depends on: | 34478 | ||
Bug Blocks: | |||
Attachments: |
Bug 36995: Correct parameter name for library EAN deletion
Bug 36995: Correct parameter name for library EAN deletion Bug 36995: Correct parameter name for library EAN deletion |
Description
Owen Leonard
2024-05-30 18:05:59 UTC
Created attachment 167284 [details] [review] Bug 36995: Correct parameter name for library EAN deletion This patches removes the "cud-" prefix from the "delete_confirm" parameter check in Library EAN management. The confirm step is a GET operation. To test, apply the patch and restart services; - Go to Administration -> Library EANs. - Add an entry if necessary, then click "Delete." - You should be taken to a confirmation page: "Confirm deletion of EAN..." - Confirm deletion and verify that the EAN was deleted. Created attachment 167287 [details] [review] Bug 36995: Correct parameter name for library EAN deletion This patches removes the "cud-" prefix from the "delete_confirm" parameter check in Library EAN management. The confirm step is a GET operation. To test, apply the patch and restart services; - Go to Administration -> Library EANs. - Add an entry if necessary, then click "Delete." - You should be taken to a confirmation page: "Confirm deletion of EAN..." - Confirm deletion and verify that the EAN was deleted. Signed-off-by: David Nind <david@davidnind.com> Testing notes (using KTD): 1. Enable the EDIFACT system preference. 2. Library EANs now appears as a heading under Administration > Acquisition parameters. Created attachment 167452 [details] [review] Bug 36995: Correct parameter name for library EAN deletion This patches removes the "cud-" prefix from the "delete_confirm" parameter check in Library EAN management. The confirm step is a GET operation. To test, apply the patch and restart services; - Go to Administration -> Library EANs. - Add an entry if necessary, then click "Delete." - You should be taken to a confirmation page: "Confirm deletion of EAN..." - Confirm deletion and verify that the EAN was deleted. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant Backported to 24.05.x for upcoming 24.05.02 This is a bug fix. Nothing to add/edit in the manual. |