Bug 36995 - Can't delete library EAN
Summary: Can't delete library EAN
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Owen Leonard
QA Contact: Martin Renvoize
URL:
Keywords:
Depends on: 34478
Blocks:
  Show dependency treegraph
 
Reported: 2024-05-30 18:05 UTC by Owen Leonard
Modified: 2024-06-27 14:08 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the Library EANs page so that EANs can be deleted. After the CSRF update in 24.05 (bug 34478), the 'Delete' action for an EAN no longer worked as it should.
Version(s) released in:
24.11.00,24.05.02


Attachments
Bug 36995: Correct parameter name for library EAN deletion (1.15 KB, patch)
2024-05-30 18:11 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 36995: Correct parameter name for library EAN deletion (1.20 KB, patch)
2024-05-30 20:04 UTC, David Nind
Details | Diff | Splinter Review
Bug 36995: Correct parameter name for library EAN deletion (1.26 KB, patch)
2024-06-05 15:14 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-05-30 18:05:59 UTC
The CSRF update added the "cud-" prefix where it should not have.
Comment 1 Owen Leonard 2024-05-30 18:11:42 UTC Comment hidden (obsolete)
Comment 2 David Nind 2024-05-30 20:04:25 UTC Comment hidden (obsolete)
Comment 3 David Nind 2024-05-30 20:14:41 UTC
Testing notes (using KTD):

1. Enable the EDIFACT system preference.
2. Library EANs now appears as a heading under Administration > Acquisition parameters.
Comment 4 Martin Renvoize 2024-06-05 15:14:30 UTC
Created attachment 167452 [details] [review]
Bug 36995: Correct parameter name for library EAN deletion

This patches removes the "cud-" prefix from the "delete_confirm"
parameter check in Library EAN management. The confirm step is a GET
operation.

To test, apply the patch and restart services;

- Go to Administration -> Library EANs.
- Add an entry if necessary, then click "Delete."
- You should be taken to a confirmation page: "Confirm deletion of
  EAN..."
- Confirm deletion and verify that the EAN was deleted.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2024-06-06 14:17:05 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 6 Lucas Gass 2024-06-27 14:08:23 UTC
Backported to 24.05.x for upcoming 24.05.02