| Summary: | 'Insert' button is not working in notices and slips tool | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Dr. Dilipkumar Vala <ddvala9> |
| Component: | Notices | Assignee: | Brendan Lawlor <blawlor> |
| Status: | Needs documenting --- | QA Contact: | Lucas Gass (lukeg) <lucas> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | blawlor, catrina, cubingguy714, david, dcook, fridolin.somers, lucas |
| Version: | Main | Keywords: | rel_23_11_candidate |
| Hardware: | All | ||
| OS: | Linux | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This fixes the button used to insert fields into the body of a notice - it was not working (Tools > Notices and slips > Edit any notice > expand a notice type > select a field on the left-hand side > Insert).
|
Version(s) released in: |
24.11.00,24.05.02
|
| Circulation function: | |||
| Bug Depends on: | 35882 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 37059: Fix insert button in notices and slips
Bug 37059: Fix insert button in notices and slips Bug 37059: Fix insert button in notices and slips |
||
|
Description
Dr. Dilipkumar Vala
2024-06-10 10:52:32 UTC
Created attachment 168016 [details] [review] Bug 37059: Fix insert button in notices and slips This patch fixes the insert button in notices and slips. The container id needed to be appened with '_panel' To Test: 1. Edit any notice or slip and try to use the insert button 2. Nothing happens 3. Apply patch and refresh the browser 4. Edit any notice or slip and use the insert button 5. Confirm the parameters are inserted into the tempalte as expected. Thx Brendan! Created attachment 168027 [details] [review] Bug 37059: Fix insert button in notices and slips This patch fixes the insert button in notices and slips. The container id needed to be appened with '_panel' To Test: 1. Edit any notice or slip and try to use the insert button 2. Nothing happens 3. Apply patch and refresh the browser 4. Edit any notice or slip and use the insert button 5. Confirm the parameters are inserted into the tempalte as expected. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> Trivial change, makes sense, scripts are happy. Passing QA Created attachment 168028 [details] [review] Bug 37059: Fix insert button in notices and slips This patch fixes the insert button in notices and slips. The container id needed to be appened with '_panel' To Test: 1. Edit any notice or slip and try to use the insert button 2. Nothing happens 3. Apply patch and refresh the browser 4. Edit any notice or slip and use the insert button 5. Confirm the parameters are inserted into the tempalte as expected. Signed-off-by: Eric Garcia <cubingguy714@gmail.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! Thank you..!! Can we get this backported to 24.05? Backported to 24.05.x for upcoming 24.05.02 Pushed to 23.11.x for 23.11.07 (In reply to Fridolin Somers from comment #10) > Pushed to 23.11.x for 23.11.07 It looks like this shouldn't have been backported to 23.11.07, as now the insert button is broken in that version. I think bug 37059 should've had a dependency on bug 35882. So 23.11.09 should revert this change... (In reply to David Cook from comment #11) > (In reply to Fridolin Somers from comment #10) > > Pushed to 23.11.x for 23.11.07 > > It looks like this shouldn't have been backported to 23.11.07, as now the > insert button is broken in that version. > > I think bug 37059 should've had a dependency on bug 35882. > > So 23.11.09 should revert this change... *ping Frido* (In reply to David Cook from comment #11) > (In reply to Fridolin Somers from comment #10) > > Pushed to 23.11.x for 23.11.07 > > It looks like this shouldn't have been backported to 23.11.07, as now the > insert button is broken in that version. > > I think bug 37059 should've had a dependency on bug 35882. > > So 23.11.09 should revert this change... Oups indeed. Reverted |