Summary: | Authorities pagination on OPAC broken by CSRF | ||
---|---|---|---|
Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
Component: | OPAC | Assignee: | Nick Clemens (kidclamp) <nick> |
Status: | CLOSED FIXED | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, emily.lamancusa, fridolin.somers, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37057 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This fixes the pagination for authority search results in the OPAC. (This is related to the CSRF changes added in Koha 24.05 to improve form security.)
|
|
Version(s) released in: |
24.11.00,24.05.02
|
Circulation function: | |
Bug Depends on: | 36192 | ||
Bug Blocks: | 38463 | ||
Attachments: |
Bug 37069: OPAC authorities search is stateless
Bug 37069: OPAC authorities search is stateless Bug 37069: OPAC authorities search is stateless |
Description
Nick Clemens (kidclamp)
2024-06-11 12:36:51 UTC
Created attachment 167630 [details] [review] Bug 37069: OPAC authorities search is stateless This patch removes cud- from the search op and chanegs the form submission to GET To test: 1 - Search authorities on OPAC for 'a' 2 - Click page 2 3 - You get the search form 4 - Apply patch, restart all 5 - Repeat search, confirm it works 6 - Click page 2 7 - Confirm you get next results Created attachment 167632 [details] [review] Bug 37069: OPAC authorities search is stateless This patch removes cud- from the search op and chanegs the form submission to GET To test: 1 - Search authorities on OPAC for 'a' 2 - Click page 2 3 - You get the search form 4 - Apply patch, restart all 5 - Repeat search, confirm it works 6 - Click page 2 7 - Confirm you get next results Signed-off-by: Owen Leonard <oleonard@myacpl.org> *** Bug 37086 has been marked as a duplicate of this bug. *** Created attachment 167757 [details] [review] Bug 37069: OPAC authorities search is stateless This patch removes cud- from the search op and chanegs the form submission to GET To test: 1 - Search authorities on OPAC for 'a' 2 - Click page 2 3 - You get the search form 4 - Apply patch, restart all 5 - Repeat search, confirm it works 6 - Click page 2 7 - Confirm you get next results Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.02 Full CSRF not in 23.11.x No updates to the manual required - the xisting image for authority search results for the OPAC doesn't show pagination. |