Bug 37069 - Authorities pagination on OPAC broken by CSRF
Summary: Authorities pagination on OPAC broken by CSRF
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens (kidclamp)
QA Contact: Emily Lamancusa
URL:
Keywords:
: 37086 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-06-11 12:36 UTC by Nick Clemens (kidclamp)
Modified: 2024-07-22 03:50 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the pagination for authority search results in the OPAC.
Version(s) released in:
24.11.00,24.05.02


Attachments
Bug 37069: OPAC authorities search is stateless (2.38 KB, patch)
2024-06-11 12:39 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 37069: OPAC authorities search is stateless (2.43 KB, patch)
2024-06-11 13:57 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37069: OPAC authorities search is stateless (2.50 KB, patch)
2024-06-14 17:58 UTC, Emily Lamancusa
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2024-06-11 12:36:51 UTC

    
Comment 1 Nick Clemens (kidclamp) 2024-06-11 12:39:27 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2024-06-11 13:57:13 UTC
Created attachment 167632 [details] [review]
Bug 37069: OPAC authorities search is stateless

This patch removes cud- from the search op and chanegs the form
submission to GET

To test:
1 - Search authorities on OPAC for 'a'
2 - Click page 2
3 - You get the search form
4 - Apply patch, restart all
5 - Repeat search, confirm it works
6 - Click page 2
7 - Confirm you get next results

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 David Nind 2024-06-13 23:19:19 UTC
*** Bug 37086 has been marked as a duplicate of this bug. ***
Comment 4 Emily Lamancusa 2024-06-14 17:58:44 UTC
Created attachment 167757 [details] [review]
Bug 37069: OPAC authorities search is stateless

This patch removes cud- from the search op and chanegs the form
submission to GET

To test:
1 - Search authorities on OPAC for 'a'
2 - Click page 2
3 - You get the search form
4 - Apply patch, restart all
5 - Repeat search, confirm it works
6 - Click page 2
7 - Confirm you get next results

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 5 Katrin Fischer 2024-06-21 13:04:31 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass 2024-07-18 19:26:56 UTC
Backported to 24.05.x for upcoming 24.05.02
Comment 7 Fridolin Somers 2024-07-19 08:36:32 UTC
Full CSRF not in 23.11.x
Comment 8 David Nind 2024-07-22 03:50:16 UTC
No updates to the manual required - the xisting image for authority search results for the OPAC doesn't show pagination.