| Summary: | Incorrect needsconfirmation code RESERVED_WAITING | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Matt Blenkinsop <matt.blenkinsop> |
| Component: | Circulation | Assignee: | Matt Blenkinsop <matt.blenkinsop> |
| Status: | Pushed to stable --- | QA Contact: | Emily Lamancusa (emlam) <emily.lamancusa> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | emily.lamancusa, gmcharlt, kyle.m.hall, lchirlias, lucas |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
24.11.00.24.05.06
|
|
| Circulation function: | |||
| Attachments: |
Bug 37076: Fix incorrect needsconfirmation code
Bug 37076: Fix incorrect needsconfirmation code Bug 37076: Fix incorrect needsconfirmation code |
||
|
Description
Matt Blenkinsop
2024-06-12 13:36:09 UTC
Created attachment 167658 [details] [review] Bug 37076: Fix incorrect needsconfirmation code This patch corrects two instances of RESERVED_WAITING to RESERVE_WAITING Test plan: 1) Navigate to system preferences and search for AllowItemsOnHoldCheckoutSCO 2) Observe from the description that the correct status code is RESERVE_WAITING 3) Search the repository for RESERVED_WAITING - you should find two instances, one in Checkouts.pm and one in checkout.js 4) Apply patch 5) Repeat step 3 - there should be 0 instances Created attachment 167883 [details] [review] Bug 37076: Fix incorrect needsconfirmation code This patch corrects two instances of RESERVED_WAITING to RESERVE_WAITING Test plan: 1) Navigate to system preferences and search for AllowItemsOnHoldCheckoutSCO 2) Observe from the description that the correct status code is RESERVE_WAITING 3) Search the repository for RESERVED_WAITING - you should find two instances, one in Checkouts.pm and one in checkout.js 4) Apply patch 5) Repeat step 3 - there should be 0 instances Signed-off-by: Lucas <lchirlias@ville-roubaix.fr> > 3) Search the repository for RESERVED_WAITING - you should find two instances, one in Checkouts.pm and one in checkout.js I checked in git.koha-community.org > 5) Repeat step 3 - there should be 0 instances I looked at the patch and it applied Created attachment 170665 [details] [review] Bug 37076: Fix incorrect needsconfirmation code This patch corrects two instances of RESERVED_WAITING to RESERVE_WAITING Test plan: 1) Navigate to system preferences and search for AllowItemsOnHoldCheckoutSCO 2) Observe from the description that the correct status code is RESERVE_WAITING 3) Search the repository for RESERVED_WAITING - you should find two instances, one in Checkouts.pm and one in checkout.js 4) Apply patch 5) Repeat step 3 - there should be 0 instances Signed-off-by: Lucas <lchirlias@ville-roubaix.fr> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Good catch! Passing QA and upgrading this to a bug, since it fixes a wrong error message in OPAC self-checkout (not the SCO module). Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.06 |