Bug 37076 - Incorrect needsconfirmation code RESERVED_WAITING
Summary: Incorrect needsconfirmation code RESERVED_WAITING
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Matt Blenkinsop
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-12 13:36 UTC by Matt Blenkinsop
Modified: 2024-11-15 17:41 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00.24.05.06
Circulation function:

Attachments
Bug 37076: Fix incorrect needsconfirmation code (2.44 KB, patch)
2024-06-12 13:40 UTC, Matt Blenkinsop 		Details | Diff | Splinter Review
Bug 37076: Fix incorrect needsconfirmation code (2.47 KB, patch)
2024-06-19 09:23 UTC, Biblibre Sandboxes 		Details | Diff | Splinter Review
Bug 37076: Fix incorrect needsconfirmation code (2.54 KB, patch)
2024-08-23 18:36 UTC, Emily Lamancusa (emlam) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-06-12 13:36:09 UTC 
There are two instances where RESERVED_WAITING is used as a needsconfirmation code when we should be using RESERVE_WAITING
Comment 1 Matt Blenkinsop 2024-06-12 13:40:09 UTC 
Created attachment 167658 [details] [review]
Bug 37076: Fix incorrect needsconfirmation code

This patch corrects two instances of RESERVED_WAITING to RESERVE_WAITING

Test plan:
1) Navigate to system preferences and search for AllowItemsOnHoldCheckoutSCO
2) Observe from the description that the correct status code is RESERVE_WAITING
3) Search the repository for RESERVED_WAITING - you should find two instances, one in Checkouts.pm and one in checkout.js
4) Apply patch
5) Repeat step 3 - there should be 0 instances
Comment 2 Biblibre Sandboxes 2024-06-19 09:23:38 UTC 
Created attachment 167883 [details] [review]
Bug 37076: Fix incorrect needsconfirmation code

This patch corrects two instances of RESERVED_WAITING to RESERVE_WAITING

Test plan:
1) Navigate to system preferences and search for AllowItemsOnHoldCheckoutSCO
2) Observe from the description that the correct status code is RESERVE_WAITING
3) Search the repository for RESERVED_WAITING - you should find two instances, one in Checkouts.pm and one in checkout.js
4) Apply patch
5) Repeat step 3 - there should be 0 instances

Signed-off-by: Lucas <lchirlias@ville-roubaix.fr>
Comment 3 Lucas 2024-06-19 09:28:05 UTC 
> 3) Search the repository for RESERVED_WAITING - you should find two instances, one in Checkouts.pm and one in checkout.js

I checked in git.koha-community.org 

> 5) Repeat step 3 - there should be 0 instances

I looked at the patch and it applied
Comment 4 Emily Lamancusa (emlam) 2024-08-23 18:36:44 UTC 
Created attachment 170665 [details] [review]
Bug 37076: Fix incorrect needsconfirmation code

This patch corrects two instances of RESERVED_WAITING to RESERVE_WAITING

Test plan:
1) Navigate to system preferences and search for AllowItemsOnHoldCheckoutSCO
2) Observe from the description that the correct status code is RESERVE_WAITING
3) Search the repository for RESERVED_WAITING - you should find two instances, one in Checkouts.pm and one in checkout.js
4) Apply patch
5) Repeat step 3 - there should be 0 instances

Signed-off-by: Lucas <lchirlias@ville-roubaix.fr>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 5 Emily Lamancusa (emlam) 2024-08-23 18:46:41 UTC 
Good catch! Passing QA and upgrading this to a bug, since it fixes a wrong error message in OPAC self-checkout (not the SCO module).
Comment 6 Katrin Fischer 2024-08-26 15:43:42 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Lucas Gass (lukeg) 2024-11-15 17:41:57 UTC 
Backported to 24.05.x for upcoming 24.05.06