Summary: | Damaged status not showing in record detail page | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | Staff interface | Assignee: | Phil Ringnalda <phil> |
Status: | RESOLVED FIXED | QA Contact: | Lucas Gass (lukeg) <lucas> |
Severity: | major | ||
Priority: | P5 - low | CC: | andrew, blawlor, Chip.Halvorsen, cj.lynce, david, ddaghita, fridolin.somers, gmcharlt, holly, jonathan.druart, jzairo, kebliss, kyle.m.hall, lucas, phil |
Version: | Main | Keywords: | regression |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes the record details page to correctly show the damaged status for an item in the holdings table status column, instead of showing it as available.
|
Version(s) released in: |
24.11.00,24.05.02
|
Circulation function: | |||
Bug Depends on: | 33568 | ||
Bug Blocks: | |||
Attachments: |
Bug 37078: Damaged status not showing in detail.pl
Bug 37078: Damaged status not showing in detail.pl Bug 37078: Damaged status not showing in detail.pl |
Description
Kelly McElligott
2024-06-12 14:25:36 UTC
Oh, also the marking an item 'withdrawn' from the patron's account, the withdrawn status doesn't show the status in the patron's account but does show the withdrawn status from the bibliographic record page This is the opposite of the first comment on this bug. Comment 1 would be something else, this is just from bug 33568 using the wrong term to find damaged in the API output it uses to build the holdings table for bib detail. Created attachment 168003 [details] [review] Bug 37078: Damaged status not showing in detail.pl The API returns the fact that an item is damaged in 'damaged_status' but the code that builds the holdings table is looking for 'damaged' so it doesn't find that an item is damaged. Test plan: 1. Administration - Authorized values - DAMAGED row, click Add 2. Give it the Authorized value 2 and the Description Awful 3. On a record with more than one item, like Empress of the blues, edit one item to have Damaged status: Damaged and one to have Damaged status: Awful 4. On the bib detail view, note that the status column shows both as 'Available' 5. Apply patch, refresh 6. Note that now one shows as Damaged and one as Awful (verifying that the value is being read from the AV, not the fallback default which is also 'Damaged') Created attachment 168021 [details] [review] Bug 37078: Damaged status not showing in detail.pl The API returns the fact that an item is damaged in 'damaged_status' but the code that builds the holdings table is looking for 'damaged' so it doesn't find that an item is damaged. Test plan: 1. Administration - Authorized values - DAMAGED row, click Add 2. Give it the Authorized value 2 and the Description Awful 3. On a record with more than one item, like Empress of the blues, edit one item to have Damaged status: Damaged and one to have Damaged status: Awful 4. On the bib detail view, note that the status column shows both as 'Available' 5. Apply patch, refresh 6. Note that now one shows as Damaged and one as Awful (verifying that the value is being read from the AV, not the fallback default which is also 'Damaged') Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Simple solution to fairly bad problem, thanks Phil. Created attachment 168068 [details] [review] Bug 37078: Damaged status not showing in detail.pl The API returns the fact that an item is damaged in 'damaged_status' but the code that builds the holdings table is looking for 'damaged' so it doesn't find that an item is damaged. Test plan: 1. Administration - Authorized values - DAMAGED row, click Add 2. Give it the Authorized value 2 and the Description Awful 3. On a record with more than one item, like Empress of the blues, edit one item to have Damaged status: Damaged and one to have Damaged status: Awful 4. On the bib detail view, note that the status column shows both as 'Available' 5. Apply patch, refresh 6. Note that now one shows as Damaged and one as Awful (verifying that the value is being read from the AV, not the fallback default which is also 'Damaged') Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! Can this be pushed to 24.05? Not showing the correct status is a significant issue for staff who use the holdings information regularly. Thx! --CJ rather, backported to 24.05 Thx! --CJ Backported to 24.05.x for upcoming 24.05.02 *** Bug 37372 has been marked as a duplicate of this bug. *** Depends on Bug 33568 not in 23.11.x |