|
Description
Owen Leonard
2024-06-17 15:27:04 UTC
Created attachment 167788 [details] [review] Bug 37103: Link log viewer options to corresponding system preference This patch updates the log viewer interface so that users with the correct permissions can click a module's "Log not enabled" icon to go directly to the corresponding system preference for enabling the log. To test, apply the patch and go to Tools -> Log viewer (must have "view_system_logs" permission). - You should see an icon next to each module for which logging is disabled. Hovering over the icon should give a tooltip: "Log not enabled." - If you are logged in as a user with "manage_sysprefs" permission, clicking the icon should take you directly to the system preference for enabling or disabling that module's logs. - If your user does not have "manage_sysprefs" permission the icon should not be a link. Sponsored-By: Athens County Public Libraries Created attachment 167800 [details] [review] Bug 37103: Link log viewer options to corresponding system preference This patch updates the log viewer interface so that users with the correct permissions can click a module's "Log not enabled" icon to go directly to the corresponding system preference for enabling the log. To test, apply the patch and go to Tools -> Log viewer (must have "view_system_logs" permission). - You should see an icon next to each module for which logging is disabled. Hovering over the icon should give a tooltip: "Log not enabled." - If you are logged in as a user with "manage_sysprefs" permission, clicking the icon should take you directly to the system preference for enabling or disabling that module's logs. - If your user does not have "manage_sysprefs" permission the icon should not be a link. Sponsored-By: Athens County Public Libraries Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> This is a nice change to the icons to have tooltips and links to the system preferences. One small thing I just noticed there is a missing space between Acquisitions and the icon. Created attachment 171782 [details] [review] This patch updates the log viewer interface so that users with the correct permissions can click a module's "Log not enabled" icon to go directly to the corresponding system preference for enabling the log. To test, apply the patch and go to Tools -> Log viewer (must have "view_system_logs" permission). - You should see an icon next to each module for which logging is disabled. Hovering over the icon should give a tooltip: "Log not enabled." - If you are logged in as a user with "manage_sysprefs" permission, clicking the icon should take you directly to the system preference for enabling or disabling that module's logs. - If your user does not have "manage_sysprefs" permission the icon should not be a link. Sponsored-By: Athens County Public Libraries Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Created attachment 171783 [details] [review] Bug 37103: (QA follow-up) Added space between Acquisitions and its icon Created attachment 171784 [details] [review] Bug 37103: Link log viewer options to corresponding system preference This patch updates the log viewer interface so that users with the correct permissions can click a module's "Log not enabled" icon to go directly to the corresponding system preference for enabling the log. To test, apply the patch and go to Tools -> Log viewer (must have "view_system_logs" permission). - You should see an icon next to each module for which logging is disabled. Hovering over the icon should give a tooltip: "Log not enabled." - If you are logged in as a user with "manage_sysprefs" permission, clicking the icon should take you directly to the system preference for enabling or disabling that module's logs. - If your user does not have "manage_sysprefs" permission the icon should not be a link. Sponsored-By: Athens County Public Libraries Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Created attachment 171785 [details] [review] Bug 37103: (QA follow-up) Added space between Acquisitions and its icon Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Pushed for 24.11! Well done everyone, thank you! |