Bug 37103 - Link log viewer options to corresponding system preference
Summary: Link log viewer options to corresponding system preference
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Laura Escamilla
URL:
Keywords:
Depends on:
Blocks: 36118
  Show dependency treegraph
 
Reported: 2024-06-17 15:27 UTC by Owen Leonard
Modified: 2024-11-18 18:25 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This patch updates the log viewer interface to show a warning icon next to each module for which logging is disabled. If the user has the correct permissions, the warning icon links directly to the corresponding system preference for enabling the log.
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37103: Link log viewer options to corresponding system preference (9.42 KB, patch)
2024-06-17 15:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37103: Link log viewer options to corresponding system preference (9.47 KB, patch)
2024-06-17 19:13 UTC, Brendan Lawlor
Details | Diff | Splinter Review
This patch updates the log viewer interface so that users with the (9.47 KB, patch)
2024-09-19 15:49 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 37103: (QA follow-up) Added space between Acquisitions and its icon (1.56 KB, patch)
2024-09-19 15:49 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 37103: Link log viewer options to corresponding system preference (9.54 KB, patch)
2024-09-19 15:50 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 37103: (QA follow-up) Added space between Acquisitions and its icon (1.63 KB, patch)
2024-09-19 15:50 UTC, Laura Escamilla
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-06-17 15:27:04 UTC
If the logged-in user has permission, we can link directly from the "Log not enabled" icon to the corresponding permission in system preferences.
Comment 1 Owen Leonard 2024-06-17 15:59:10 UTC
Created attachment 167788 [details] [review]
Bug 37103: Link log viewer options to corresponding system preference

This patch updates the log viewer interface so that users with the
correct permissions can click a module's "Log not enabled" icon to go
directly to the corresponding system preference for enabling the log.

To test, apply the patch and go to Tools -> Log viewer (must have
"view_system_logs" permission).

- You should see an icon next to each module for which logging is
  disabled. Hovering over the icon should give a tooltip: "Log not
  enabled."
- If you are logged in as a user with "manage_sysprefs" permission,
  clicking the icon should take you directly to the system preference
  for enabling or disabling that module's logs.
- If your user does not have "manage_sysprefs" permission the icon
  should not be a link.

Sponsored-By: Athens County Public Libraries
Comment 2 Brendan Lawlor 2024-06-17 19:13:10 UTC
Created attachment 167800 [details] [review]
Bug 37103: Link log viewer options to corresponding system preference

This patch updates the log viewer interface so that users with the
correct permissions can click a module's "Log not enabled" icon to go
directly to the corresponding system preference for enabling the log.

To test, apply the patch and go to Tools -> Log viewer (must have
"view_system_logs" permission).

- You should see an icon next to each module for which logging is
  disabled. Hovering over the icon should give a tooltip: "Log not
  enabled."
- If you are logged in as a user with "manage_sysprefs" permission,
  clicking the icon should take you directly to the system preference
  for enabling or disabling that module's logs.
- If your user does not have "manage_sysprefs" permission the icon
  should not be a link.

Sponsored-By: Athens County Public Libraries
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 3 Brendan Lawlor 2024-06-17 19:44:26 UTC
This is a nice change to the icons to have tooltips and links to the system preferences.


One small thing I just noticed there is a missing space between Acquisitions and the icon.
Comment 4 Laura Escamilla 2024-09-19 15:49:39 UTC
Created attachment 171782 [details] [review]
This patch updates the log viewer interface so that users with the

correct permissions can click a module's "Log not enabled" icon to go
directly to the corresponding system preference for enabling the log.

To test, apply the patch and go to Tools -> Log viewer (must have
"view_system_logs" permission).

- You should see an icon next to each module for which logging is
  disabled. Hovering over the icon should give a tooltip: "Log not
  enabled."
- If you are logged in as a user with "manage_sysprefs" permission,
  clicking the icon should take you directly to the system preference
  for enabling or disabling that module's logs.
- If your user does not have "manage_sysprefs" permission the icon
  should not be a link.

Sponsored-By: Athens County Public Libraries
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 5 Laura Escamilla 2024-09-19 15:49:41 UTC
Created attachment 171783 [details] [review]
Bug 37103: (QA follow-up) Added space between Acquisitions and its icon
Comment 6 Laura Escamilla 2024-09-19 15:50:58 UTC
Created attachment 171784 [details] [review]
Bug 37103: Link log viewer options to corresponding system preference

This patch updates the log viewer interface so that users with the
correct permissions can click a module's "Log not enabled" icon to go
directly to the corresponding system preference for enabling the log.

To test, apply the patch and go to Tools -> Log viewer (must have
"view_system_logs" permission).

- You should see an icon next to each module for which logging is
  disabled. Hovering over the icon should give a tooltip: "Log not
  enabled."
- If you are logged in as a user with "manage_sysprefs" permission,
  clicking the icon should take you directly to the system preference
  for enabling or disabling that module's logs.
- If your user does not have "manage_sysprefs" permission the icon
  should not be a link.

Sponsored-By: Athens County Public Libraries
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 7 Laura Escamilla 2024-09-19 15:50:59 UTC
Created attachment 171785 [details] [review]
Bug 37103: (QA follow-up) Added space between Acquisitions and its icon

Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 8 Katrin Fischer 2024-10-18 15:45:49 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 9 Philip Orr 2024-11-08 15:06:28 UTC
Added release notes