|
Description
Matt Blenkinsop
2024-06-18 13:44:34 UTC
Created attachment 167847 [details] [review] Bug 37115: Delete linked serial when deleting a single item Created attachment 167848 [details] [review] Bug 37115: Batch delete linked serials OK for deleting a single item and linked serial. KO for batch delete linked serials. Items are deleted but not linked serials. Created attachment 168133 [details] [review] Bug 37115: Delete linked serial when deleting a single item Created attachment 168134 [details] [review] Bug 37115: Batch delete linked serials Hello Matt. Thanks for your work and your interest in the serial matters ! Can you provide a test plan ? It will be better for a correct sign off. Thanks. Created attachment 168373 [details] [review] Bug 37115: Delete linked serial when deleting a single item Created attachment 168374 [details] [review] Bug 37115: Batch delete linked serials Here's a test plan for 'Delete linked serial when deleting a single item' : - Add a new subscription to a serial notice (with option 'create an item record') - Receive one issue and create the item linked - Back to bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - Back to subscription : the issue linked to item doesn't exist any more Hello Matt. I confirm that the patch 'deleting a single item and linked serial' works. But the second 'Batch deleted linked serials' does not meet expectations. Issues are still presents after the items have been deleted. Here's a test plan for 'Batch delete linked serials' : - Add a new subscription to a serial record (with option 'create an item record') - Receive several issues and create the items linked - Back to bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - Back to subscription : the issues linked to items should no longer exist Created attachment 168495 [details] [review] Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more Created attachment 168496 [details] [review] Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist Created attachment 168497 [details] [review] Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Created attachment 171208 [details] [review] Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more Created attachment 171209 [details] [review] Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist Created attachment 171210 [details] [review] Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Early QA: this is going to conflict with bug 37637. Saying that because you are using a bad pattern: using a TT plugin to retrieve additional info from items (it will cause 1 additional fetch + a JOIN per item). With bug 37637 you will be able to retrieve this information from the REST API and get rid of this TT plugin. `api/v1/swagger/definitions/item.yaml: serial_item` The downside is that it is a non-trivial change and you don't know when it will be pushed... Hi Matthew. the link "Delete >>>>>>> Bug 37115: Delete linked serial when deleting a single item" is inactive. And for batch delete, items are deleted but not linked serials. Created attachment 171938 [details] [review] Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more Created attachment 171939 [details] [review] Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist Created attachment 171940 [details] [review] Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t (In reply to Jonathan Druart from comment #18) > Early QA: this is going to conflict with bug 37637. > > Saying that because you are using a bad pattern: using a TT plugin to > retrieve additional info from items (it will cause 1 additional fetch + a > JOIN per item). > > With bug 37637 you will be able to retrieve this information from the REST > API and get rid of this TT plugin. > `api/v1/swagger/definitions/item.yaml: serial_item` > > The downside is that it is a non-trivial change and you don't know when it > will be pushed... I've fixed the patches and reattached them using the TT plugin so that Nathalie can test them to check that the functionality is what she is expecting. Once we are happy with the concept I will look to rebase on 37637 and see what assistance is needed on that bug to help get this one through Created attachment 173256 [details] [review] Bug 37115: Delete linked serial when deleting a single item Test plan: - Add a new subscription to a serial notice (with the option 'create an item record' selected) - Receive one issue and create the linked item - Return to the bibliographic record - Edit item - Action - Delete - Tick the box 'delete serial issues linked to item' and confirm - The item should still be deleted correctly - Back to subscription : the issue linked to the item doesn't exist any more Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Created attachment 173257 [details] [review] Bug 37115: Batch delete linked serials Test plan: - Add a new subscription to a serial record (with the option 'create an item record' selected) - Receive several issues and create the linked items - Return to the bibliographic record - Select several items - Click to 'Delete selected items' - Tick the box 'delete serial issues linked to items' and confirm - The items should be deleted correctly - Back to subscription : the issues linked to items should no longer exist Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> Created attachment 173258 [details] [review] Bug 37115: Add unit tests prove t/db_dependent/Koha/Item.t prove t/db_dependent/Koha/BackgroundJobs/BatchDeleteItem.t Signed-off-by: Boubacar OUATTARA <boubacar.ouattara@biblibre.com> |