The batch record deletion tool checks for items, holds and checkouts. It would be a nice enhancement to also show linked subscriptions and orders. This would then match the checks done in acquisitions in order to be able to delete the record when cancelling an order line.
*** Bug 14271 has been marked as a duplicate of this bug. ***
Created attachment 147641 [details] [review] Bug 13870: Added a visual warning message on the item batch form I tried to add a visual warn on item linked to subscription or concern by an order. I don't think that pop-up could be the solution so I put a warn triangle aside the delete action to I don't think another pop-up is the ideal solution so I chose to integrate a yellow triangle right next to the action leading to the deletion of the 'item' with a hover message if a subscription or order is linked. I'm looking forward to your feedback :) Test plan : 1) Apply this patch 2) Be sure to have item with order or can concern by a subscription 3) Edit them to go on the batch form 4) See the yellow triangle next to the 'delete' action in 'actions' dropdown menu
Created attachment 152235 [details] [review] Bug 13870: Added a visual warning message on the item batch form I add a visual warn on item linked to subscription or concern by an order. I don't think that pop-up could be the solution so I put a warn triangle aside the delete action to I don't think another pop-up is the ideal solution so I chose to integrate a yellow triangle right next to the action leading to the deletion of the 'item' with a hover message if a subscription or order is linked. I'm looking forward to your feedback :) Test plan : 1) Apply this patch 2) Be sure to have item with order or can concern by a subscription 3) Edit them to go on the batch form 4) See the yellow triangle next to the 'delete' action in 'actions' dropdown menu
Created attachment 152236 [details] [review] Bug 13870: Add columns in batch delete mode
Created attachment 155576 [details] [review] Bug 13870: Add columns in batch delete mode Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Hi Thibaud, I was excited to see this, but it turned out a little bit different to what I had expected: 1) The bug was filed for the 'batch record deletion tool'. Your patch deals with deleting single items. This can be fixed rather easily by changing the bug description and re-filing (see bug 35005) 2) For orders, I think we need to make some difference between an order that has been completed and one that is still pending. Deleting an item that is linked to a pending order would get us in trouble. Throwing out an old item purchased long ago not. Concerning order status would be: new, ordered, partial OK to delete: cancelled, complete 4) This line appears unrelated to the intention of the patch: + $i->{nomod} = 1 unless $patron->can_edit_items_from($item->homebranch); 5) The warnings messages you created are untranslatable, they need to be moved into the templates: cataloguing/additem.pl + if ($i_order) { + $warning_messages{$i->{itemnumber}} = sprintf('There is an order (ordernumber %s) on this item', $i_order->{ordernumber} ); + } + if ($i_serialid) { + $warning_messages{$i->{itemnumber}} = 'A subscription is linked to this item' 6) The subscription count on item batch modification doesn't seem to work right. I added a subscription and created an item on receiving an issue, so it's linked to the subscription. But it still said "None" on the batch mod page. 7) The order count on item batch modification doesn't appear to work either. I added an order with 'create items on order' and that item to the batch edit - The column remained at "None". 8) The notes work OK on the normal item editing form. I like the approach with the little warning sign. 9) QA tools are failing for a missing filter and tidiness.
Hi, my $i_order = GetOrderFromItemnumber($itemnumber); my $i_serialid = Koha::Serial::Items->search( {itemnumber => $itemnumber} )->get_column('serialid'); Is there a performance impact ? Better prefetch linked tables maybe.
Created attachment 175440 [details] [review] Bug 13870: Added a visual warning message on the item batch form I add a visual warn on item linked to subscription or concern by an order. I don't think that pop-up could be the solution so I put a warn triangle aside the delete action to I don't think another pop-up is the ideal solution so I chose to integrate a yellow triangle right next to the action leading to the deletion of the 'item' with a hover message if a subscription or order is linked. I'm looking forward to your feedback :) Test plan : 1) Apply this patch 2) Be sure to have item with order or can concern by a subscription 3) Edit them to go on the batch form 4) See the yellow triangle next to the 'delete' action in 'actions' dropdown menu
Hello all, I've just rebased it, thanks Katrin for your review, and Frido too ! I've changed my request to use prefetch like Frido said and I also fix the missing filter. For the tidiness.. I've tried to found it but maybe a "false positive" ?
Hi Thibaud, we tested the patch during Hackathon KohaLa today. Ok for one item (linked with a subscription) but not for batch delete mode. I think we can link the patch with BZ 37115 (Add the option to delete linked serials when deleting items) from items linked with a subscription.
If I understand correctly a problem was found during testing, so that would be failed QA. At least this need to be clarified to not make other testers hesitate whether to test or not.
Created attachment 176858 [details] [review] Bug 13870: Add warn about linked order or/and subscription on batch item table When you try to manage/delete/edit items I added an info about linked order or/and linked subscription. Test plan : 1) Apply this patch 2) Restart_all 3) Be sure to have item with order or can concern by a subscription 4) On biblio record page click on Edit -> Manage items 5) See the yellow triangle next to the 'delete' action in 'actions' dropdown menu (with subscription id or ordernumber hover the symbol) 6) When you edit or delete items (batch mode) you can see two new columns about orders and subscriptions linked. Sponsored by: BibLibre