Description
Matt Blenkinsop
2024-06-18 13:55:59 UTC
Created attachment 167849 [details] [review] Bug 37116: Redirect to serial modification when modifying an item Created attachment 167850 [details] [review] Bug 37116: Redirect to batch serial modification when batch modifying items Created attachment 167881 [details] [review] Bug 37116: Redirect to serial modification when modifying an item Created attachment 167882 [details] [review] Bug 37116: Redirect to batch serial modification when batch modifying items Created attachment 168135 [details] [review] Bug 37116: Redirect to serial modification when modifying an item (cherry picked from commit 02adb9082a7564bba4a861acd2a718daeff19c15) Created attachment 168136 [details] [review] Bug 37116: Redirect to batch serial modification when batch modifying items (cherry picked from commit 786f27d7796b0ef2e7b3933feb8fddbf3695630a) Created attachment 168137 [details] [review] Bug 37116: Redirect to serial modification when modifying an item Created attachment 168138 [details] [review] Bug 37116: Redirect to batch serial modification when batch modifying items Hello Matt. Thanks for your work and your interest in the serial matters ! Can you provide a test plan ? It will be better for a correct sign off. Thanks. Created attachment 168375 [details] [review] Bug 37116: Redirect to serial modification when modifying an item Created attachment 168376 [details] [review] Bug 37116: Redirect to batch serial modification when batch modifying items Here's a test plan for 'Redirect to serial modification when modifying an item' : - Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record') - Receive one issue and create the item linked - Back to bibliographic record - Edit item and modifying data - Save changes - A box opens indicating that an issue is linked to the item. - Click on "Edit serial issue" - We switch to the issue - Modifying data of the issue and save Both modifications (item and issue) are validated Hello Matt. Both modifications are validated for the option "modifying an item". But, after validating them, we arrive on a blank page. Could be possible to come back to the subscription page of our serial ? Or to the serial record ? Here's a test plan for 'Redirect to batch serial modification when batch modifying items' : - Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record') - Receive several issues and create the items linked - Back to bibliographic record - Select several items and click to 'Modify selected items' - Modify data (like add a public note) - A box opens indicating that 'some of the items have linked serial issues, would you like to edit these as well ?' - Click on "Edit serial issue" - We switch to the issues - Modify data of the issues (add a note for example like for the items) and save Both modifications (item and issue) are validated Matt, both modifications are validated for the second option "batch modifying items". But, after validating them, we arrive on a blank page like the first option. Could be possible to come back to the subscription page of our serial ? Or to the serial record ? Created attachment 168498 [details] [review] Bug 37116: Redirect to serial modification when modifying an item Created attachment 168499 [details] [review] Bug 37116: Redirect to batch serial modification when batch modifying items Created attachment 168500 [details] [review] Bug 37116: Redirect to serial modification when modifying an item Test plan: - Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record') - Receive one issue and create the item linked - Back to bibliographic record - Edit item and modifying data - Save changes - A box opens indicating that an issue is linked to the item. - Click on "Edit serial issue" - We switch to the issue - Modifying data of the issue and save - Both modifications (item and issue) are validated Created attachment 168501 [details] [review] Bug 37116: Redirect to batch serial modification when batch modifying items Test plan: - Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record') - Receive several issues and create the items linked - Back to bibliographic record - Select several items and click to 'Modify selected items' - Modify data (like add a public note) - A box opens indicating that 'some of the items have linked serial issues, would you like to edit these as well ?' - Click on "Edit serial issue" - We switch to the issues - Modify data of the issues (add a note for example like for the items) and save - Both modifications (item and issue) are validated Created attachment 171211 [details] [review] Bug 37116: Redirect to serial modification when modifying an item Test plan: - Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record') - Receive one issue and create the item linked - Back to bibliographic record - Edit item and modifying data - Save changes - A box opens indicating that an issue is linked to the item. - Click on "Edit serial issue" - We switch to the issue - Modifying data of the issue and save - Both modifications (item and issue) are validated Created attachment 171212 [details] [review] Bug 37116: Redirect to batch serial modification when batch modifying items Test plan: - Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record') - Receive several issues and create the items linked - Back to bibliographic record - Select several items and click to 'Modify selected items' - Modify data (like add a public note) - A box opens indicating that 'some of the items have linked serial issues, would you like to edit these as well ?' - Click on "Edit serial issue" - We switch to the issues - Modify data of the issues (add a note for example like for the items) and save - Both modifications (item and issue) are validated Hi Matthew. 'Save changes' button no longer works, nor does 'Save' button for batch changes Created attachment 171942 [details] [review] Bug 37116: Redirect to serial modification when modifying an item Test plan: - Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record') - Receive one issue and create the item linked - Back to bibliographic record - Edit item and modifying data - Save changes - A box opens indicating that an issue is linked to the item. - Click on "Edit serial issue" - We switch to the issue - Modifying data of the issue and save - Both modifications (item and issue) are validated Created attachment 171943 [details] [review] Bug 37116: Redirect to batch serial modification when batch modifying items Test plan: - Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record') - Receive several issues and create the items linked - Back to bibliographic record - Select several items and click to 'Modify selected items' - Modify data (like add a public note) - A box opens indicating that 'some of the items have linked serial issues, would you like to edit these as well ?' - Click on "Edit serial issue" - We switch to the issues - Modify data of the issues (add a note for example like for the items) and save - Both modifications (item and issue) are validated Hi. Does the bug status need to be changed to "Need sign-off"? Created attachment 174882 [details] [review] Bug 37116: Redirect to serial modification when modifying an item Test plan: - Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record') - Receive one issue and create the item linked - Back to bibliographic record - Edit item and modifying data - Save changes - A box opens indicating that an issue is linked to the item. - Click on "Edit serial issue" - We switch to the issue - Modifying data of the issue and save - Both modifications (item and issue) are validated Created attachment 174883 [details] [review] Bug 37116: Redirect to batch serial modification when batch modifying items Test plan: - Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record') - Receive several issues and create the items linked - Back to bibliographic record - Select several items and click to 'Modify selected items' - Modify data (like add a public note) - A box opens indicating that 'some of the items have linked serial issues, would you like to edit these as well ?' - Click on "Edit serial issue" - We switch to the issues - Modify data of the issues (add a note for example like for the items) and save - Both modifications (item and issue) are validated Hi Boubacar, do you have feedback for why the patches Failed QA? - I manage to add a new subscription to a series sheet (with option 'When receiving the series --> And create an item sheet') - Receive multiple numbers and create related items - Return to the bibliographic record - I select several elements and click on 'Edit selected elements' - I modify the data (like adding a public note) ->But the box does not open as indicated Hi, On the Ptfs sandboxes, no problem, the patch works. I'm switching over to the associated issues. I tested again at the end of November. Which sandbox do you use? Tested on Hackathon KohaLa Lyon, 13th january 2025. You can add the sign off of GT Périodiques KohaLa with people from Koha team Lyon 3 : koha@univ-lyon3.fr Feel free to give more details if you still have issues when testing. Created attachment 176438 [details] [review] Bug 37116: Redirect to serial modification when modifying an item Test plan: - Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record') - Receive one issue and create the item linked - Back to bibliographic record - Edit item and modifying data - Save changes - A box opens indicating that an issue is linked to the item. - Click on "Edit serial issue" - We switch to the issue - Modifying data of the issue and save - Both modifications (item and issue) are validated Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> Created attachment 176439 [details] [review] Bug 37116: Redirect to batch serial modification when batch modifying items Test plan: - Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record') - Receive several issues and create the items linked - Back to bibliographic record - Select several items and click to 'Modify selected items' - Modify data (like add a public note) - A box opens indicating that 'some of the items have linked serial issues, would you like to edit these as well ?' - Click on "Edit serial issue" - We switch to the issues - Modify data of the issues (add a note for example like for the items) and save - Both modifications (item and issue) are validated Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr> Sorry to bring the bad news Matt, but a small merge conflict to solve in tools/batchMod-edit.tt now. |