Bug 37116

Summary: Add the option to edit linked serials when editing items
Product: Koha Reporter: Matt Blenkinsop <matt.blenkinsop>
Component: SerialsAssignee: Matt Blenkinsop <matt.blenkinsop>
Status: Patch doesn't apply --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: boubacar.ouattara, koha, lucas, martin.aubeut, mathsabypro, melanie.catt, nathalie.savarit, pauline.jouve, sophie.wawrzyniak
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 37115    
Bug Blocks:    
Attachments: Bug 37116: Redirect to serial modification when modifying an item
Bug 37116: Redirect to batch serial modification when batch modifying items
Bug 37116: Redirect to serial modification when modifying an item
Bug 37116: Redirect to batch serial modification when batch modifying items
Bug 37116: Redirect to serial modification when modifying an item
Bug 37116: Redirect to batch serial modification when batch modifying items
Bug 37116: Redirect to serial modification when modifying an item
Bug 37116: Redirect to batch serial modification when batch modifying items
Bug 37116: Redirect to serial modification when modifying an item
Bug 37116: Redirect to batch serial modification when batch modifying items
Bug 37116: Redirect to serial modification when modifying an item
Bug 37116: Redirect to batch serial modification when batch modifying items
Bug 37116: Redirect to serial modification when modifying an item
Bug 37116: Redirect to batch serial modification when batch modifying items
Bug 37116: Redirect to serial modification when modifying an item
Bug 37116: Redirect to batch serial modification when batch modifying items
Bug 37116: Redirect to serial modification when modifying an item
Bug 37116: Redirect to batch serial modification when batch modifying items
Bug 37116: Redirect to serial modification when modifying an item
Bug 37116: Redirect to batch serial modification when batch modifying items
Bug 37116: Redirect to serial modification when modifying an item
Bug 37116: Redirect to batch serial modification when batch modifying items

Description Matt Blenkinsop 2024-06-18 13:55:59 UTC

    
Comment 1 Matt Blenkinsop 2024-06-18 13:58:08 UTC
Created attachment 167849 [details] [review]
Bug 37116: Redirect to serial modification when modifying an item
Comment 2 Matt Blenkinsop 2024-06-18 13:58:10 UTC
Created attachment 167850 [details] [review]
Bug 37116: Redirect to batch serial modification when batch modifying items
Comment 3 Matt Blenkinsop 2024-06-19 08:52:52 UTC
Created attachment 167881 [details] [review]
Bug 37116: Redirect to serial modification when modifying an item
Comment 4 Matt Blenkinsop 2024-06-19 08:52:55 UTC
Created attachment 167882 [details] [review]
Bug 37116: Redirect to batch serial modification when batch modifying items
Comment 5 Matt Blenkinsop 2024-06-26 10:59:30 UTC
Created attachment 168135 [details] [review]
Bug 37116: Redirect to serial modification when modifying an item

(cherry picked from commit 02adb9082a7564bba4a861acd2a718daeff19c15)
Comment 6 Matt Blenkinsop 2024-06-26 10:59:32 UTC
Created attachment 168136 [details] [review]
Bug 37116: Redirect to batch serial modification when batch modifying items

(cherry picked from commit 786f27d7796b0ef2e7b3933feb8fddbf3695630a)
Comment 7 Matt Blenkinsop 2024-06-26 11:00:45 UTC
Created attachment 168137 [details] [review]
Bug 37116: Redirect to serial modification when modifying an item
Comment 8 Matt Blenkinsop 2024-06-26 11:00:47 UTC
Created attachment 168138 [details] [review]
Bug 37116: Redirect to batch serial modification when batch modifying items
Comment 9 Martin AUBEUT 2024-06-26 16:36:05 UTC
Hello Matt. Thanks for your work and your interest in the serial matters ! Can you provide a test plan ? It will be better for a correct sign off. Thanks.
Comment 10 Matt Blenkinsop 2024-07-02 15:15:10 UTC
Created attachment 168375 [details] [review]
Bug 37116: Redirect to serial modification when modifying an item
Comment 11 Matt Blenkinsop 2024-07-02 15:15:13 UTC
Created attachment 168376 [details] [review]
Bug 37116: Redirect to batch serial modification when batch modifying items
Comment 12 Nathalie SAVARIT 2024-07-04 08:07:45 UTC
Here's a test plan for 'Redirect to serial modification when modifying an item' : 

- Add a new subscription to a serial record
(with option 'When receiving the serial --> create an item record')
- Receive one issue and create the item linked
- Back to bibliographic record
- Edit item and modifying data
- Save changes
- A box opens indicating that an issue is linked to the item. 
- Click on "Edit serial issue"
- We switch to the issue
- Modifying data of the issue and save

Both modifications (item and issue) are validated
Comment 13 Nathalie SAVARIT 2024-07-04 08:14:07 UTC
Hello Matt. Both modifications are validated for the option "modifying an item".
But, after validating them, we arrive on a blank page. 
Could be possible to come back to the subscription page of our serial ?
Or to the serial record ?
Comment 14 Nathalie SAVARIT 2024-07-04 08:34:23 UTC
Here's a test plan for 'Redirect to batch serial modification when batch modifying items' : 

- Add a new subscription to a serial record
(with option 'When receiving the serial --> create an item record')
- Receive several issues and create the items linked
- Back to bibliographic record
- Select several items and click to 'Modify selected items'
- Modify data (like add a public note)
- A box opens indicating that 'some of the items have linked serial issues, would you like to edit these as well ?' 
- Click on "Edit serial issue"
- We switch to the issues
- Modify data of the issues (add a note for example like for the items) and save

Both modifications (item and issue) are validated
Comment 15 Nathalie SAVARIT 2024-07-04 08:36:01 UTC
Matt, both modifications are validated for the second option "batch modifying items".
But, after validating them, we arrive on a blank page like the first option. 
Could be possible to come back to the subscription page of our serial ?
Or to the serial record ?
Comment 16 Matt Blenkinsop 2024-07-04 11:52:16 UTC
Created attachment 168498 [details] [review]
Bug 37116: Redirect to serial modification when modifying an item
Comment 17 Matt Blenkinsop 2024-07-04 11:52:20 UTC
Created attachment 168499 [details] [review]
Bug 37116: Redirect to batch serial modification when batch modifying items
Comment 18 Matt Blenkinsop 2024-07-04 11:57:17 UTC
Created attachment 168500 [details] [review]
Bug 37116: Redirect to serial modification when modifying an item

Test plan:
- Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record')
- Receive one issue and create the item linked
- Back to bibliographic record
- Edit item and modifying data
- Save changes
- A box opens indicating that an issue is linked to the item.
- Click on "Edit serial issue"
- We switch to the issue
- Modifying data of the issue and save
- Both modifications (item and issue) are validated
Comment 19 Matt Blenkinsop 2024-07-04 11:57:20 UTC
Created attachment 168501 [details] [review]
Bug 37116: Redirect to batch serial modification when batch modifying items

Test plan:
- Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record')
- Receive several issues and create the items linked
- Back to bibliographic record
- Select several items and click to 'Modify selected items'
- Modify data (like add a public note)
- A box opens indicating that 'some of the items have linked serial issues, would you like to edit these as well ?'
- Click on "Edit serial issue"
- We switch to the issues
- Modify data of the issues (add a note for example like for the items) and save
- Both modifications (item and issue) are validated
Comment 20 Matt Blenkinsop 2024-09-09 15:39:44 UTC
Created attachment 171211 [details] [review]
Bug 37116: Redirect to serial modification when modifying an item

Test plan:
- Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record')
- Receive one issue and create the item linked
- Back to bibliographic record
- Edit item and modifying data
- Save changes
- A box opens indicating that an issue is linked to the item.
- Click on "Edit serial issue"
- We switch to the issue
- Modifying data of the issue and save
- Both modifications (item and issue) are validated
Comment 21 Matt Blenkinsop 2024-09-09 15:39:46 UTC
Created attachment 171212 [details] [review]
Bug 37116: Redirect to batch serial modification when batch modifying items

Test plan:
- Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record')
- Receive several issues and create the items linked
- Back to bibliographic record
- Select several items and click to 'Modify selected items'
- Modify data (like add a public note)
- A box opens indicating that 'some of the items have linked serial issues, would you like to edit these as well ?'
- Click on "Edit serial issue"
- We switch to the issues
- Modify data of the issues (add a note for example like for the items) and save
- Both modifications (item and issue) are validated
Comment 22 Nathalie SAVARIT 2024-09-12 08:40:54 UTC
Hi Matthew. 'Save changes' button no longer works, nor does 'Save' button for batch changes
Comment 23 Matt Blenkinsop 2024-09-24 14:28:50 UTC
Created attachment 171942 [details] [review]
Bug 37116: Redirect to serial modification when modifying an item

Test plan:
- Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record')
- Receive one issue and create the item linked
- Back to bibliographic record
- Edit item and modifying data
- Save changes
- A box opens indicating that an issue is linked to the item.
- Click on "Edit serial issue"
- We switch to the issue
- Modifying data of the issue and save
- Both modifications (item and issue) are validated
Comment 24 Matt Blenkinsop 2024-09-24 14:28:52 UTC
Created attachment 171943 [details] [review]
Bug 37116: Redirect to batch serial modification when batch modifying items

Test plan:
- Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record')
- Receive several issues and create the items linked
- Back to bibliographic record
- Select several items and click to 'Modify selected items'
- Modify data (like add a public note)
- A box opens indicating that 'some of the items have linked serial issues, would you like to edit these as well ?'
- Click on "Edit serial issue"
- We switch to the issues
- Modify data of the issues (add a note for example like for the items) and save
- Both modifications (item and issue) are validated
Comment 25 Mathieu Saby 2024-10-31 14:05:57 UTC
Hi. Does the bug status need to be changed to "Need sign-off"?
Comment 26 Matt Blenkinsop 2024-11-21 14:15:14 UTC
Created attachment 174882 [details] [review]
Bug 37116: Redirect to serial modification when modifying an item

Test plan:
- Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record')
- Receive one issue and create the item linked
- Back to bibliographic record
- Edit item and modifying data
- Save changes
- A box opens indicating that an issue is linked to the item.
- Click on "Edit serial issue"
- We switch to the issue
- Modifying data of the issue and save
- Both modifications (item and issue) are validated
Comment 27 Matt Blenkinsop 2024-11-21 14:15:16 UTC
Created attachment 174883 [details] [review]
Bug 37116: Redirect to batch serial modification when batch modifying items

Test plan:
- Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record')
- Receive several issues and create the items linked
- Back to bibliographic record
- Select several items and click to 'Modify selected items'
- Modify data (like add a public note)
- A box opens indicating that 'some of the items have linked serial issues, would you like to edit these as well ?'
- Click on "Edit serial issue"
- We switch to the issues
- Modify data of the issues (add a note for example like for the items) and save
- Both modifications (item and issue) are validated
Comment 28 Matt Blenkinsop 2024-12-16 09:30:54 UTC
Hi Boubacar, do you have feedback for why the patches Failed QA?
Comment 29 Boubacar OUATTARA 2024-12-16 09:51:06 UTC
- I manage to add a new subscription to a series sheet (with option 'When receiving the series --> And create an item sheet')
- Receive multiple numbers and create related items
- Return to the bibliographic record
- I select several elements and click on 'Edit selected elements'
- I modify the data (like adding a public note)
->But the box does not open as indicated
Comment 30 Nathalie SAVARIT 2024-12-16 10:12:03 UTC
Hi,
On the Ptfs sandboxes, no problem, the patch works. I'm switching over to the associated issues. I tested again at the end of November. 
Which sandbox do you use?
Comment 31 Nathalie SAVARIT 2025-01-13 13:18:50 UTC
Tested on Hackathon KohaLa Lyon, 13th january 2025.
You can add the sign off of GT Périodiques KohaLa with people from
Koha team Lyon 3 : koha@univ-lyon3.fr
Comment 32 Nathalie SAVARIT 2025-01-13 13:19:54 UTC
Feel free to give more details if you still have issues when testing.
Comment 33 Biblibre Sandboxes 2025-01-13 13:35:23 UTC
Created attachment 176438 [details] [review]
Bug 37116: Redirect to serial modification when modifying an item

Test plan:
- Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record')
- Receive one issue and create the item linked
- Back to bibliographic record
- Edit item and modifying data
- Save changes
- A box opens indicating that an issue is linked to the item.
- Click on "Edit serial issue"
- We switch to the issue
- Modifying data of the issue and save
- Both modifications (item and issue) are validated

Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr>
Comment 34 Biblibre Sandboxes 2025-01-13 13:35:25 UTC
Created attachment 176439 [details] [review]
Bug 37116: Redirect to batch serial modification when batch modifying items

Test plan:
- Add a new subscription to a serial record (with option 'When receiving the serial --> create an item record')
- Receive several issues and create the items linked
- Back to bibliographic record
- Select several items and click to 'Modify selected items'
- Modify data (like add a public note)
- A box opens indicating that 'some of the items have linked serial issues, would you like to edit these as well ?'
- Click on "Edit serial issue"
- We switch to the issues
- Modify data of the issues (add a note for example like for the items) and save
- Both modifications (item and issue) are validated

Signed-off-by: Nathalie <nathalie.savarit@univ-amu.fr>
Comment 35 Lucas Gass (lukeg) 2025-01-31 16:57:11 UTC
Sorry to bring the bad news Matt, but a small merge conflict to solve in tools/batchMod-edit.tt now.