Bug 37129

Summary: Patron attributes linked to an authorized value don't show a select menu in batch modification
Product: Koha Reporter: Phil Ringnalda <phil>
Component: ToolsAssignee: Phil Ringnalda <phil>
Status: RESOLVED FIXED QA Contact: Emily Lamancusa (emlam) <emily.lamancusa>
Severity: major    
Priority: P5 - low CC: david, emily.lamancusa, fridolin.somers, hebah, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
This fixes the patron batch modification tool so that patron attributes linked to an authorized value now show the dropdown list of values. (This is related to the CSRF changes added in Koha 24.05 to improve form security.)
Version(s) released in:
24.11.00,24.05.02
Circulation function:
Bug Depends on:    
Bug Blocks: 36192    
Attachments: Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification
Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification
Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification

Description Phil Ringnalda 2024-06-19 17:44:54 UTC
If you have a patron attribute linked to an authorized value (like we do by default for "Show barcode on the summary screen items listings") then in patron batch modification rather than getting a select menu to choose an authorized value to change to, you just get a text input, thanks to a stray cud-.
Comment 1 Phil Ringnalda 2024-06-19 17:57:09 UTC
Created attachment 167885 [details] [review]
Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification

Test plan:
1. In Administration - Patron attribute types verify you have the default
   SHOW_BCODE using the YES_NO authorized value
2. Tools - Batch patron modification, add a patron card number or
   borrowernumber and continue
3. For Patron attribute select Show barcode on the summary screen item
   listings, and note that you get a blank text input rather than a select
   menu with Yes and No choices
4. Apply patch, restart_all
5. Repeat step 2 and 3, but note that you now get a Yes/No select menu
Comment 2 David Nind 2024-06-19 19:02:28 UTC
Created attachment 167894 [details] [review]
Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification

Test plan:
1. In Administration - Patron attribute types verify you have the default
   SHOW_BCODE using the YES_NO authorized value
2. Tools - Batch patron modification, add a patron card number or
   borrowernumber and continue
3. For Patron attribute select Show barcode on the summary screen item
   listings, and note that you get a blank text input rather than a select
   menu with Yes and No choices
4. Apply patch, restart_all
5. Repeat step 2 and 3, but note that you now get a Yes/No select menu

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-06-19 19:06:49 UTC
Thanks Phil for adding a patch so quickly to fix this!
Comment 4 Emily Lamancusa (emlam) 2024-06-20 20:36:50 UTC
Created attachment 167941 [details] [review]
Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification

Test plan:
1. In Administration - Patron attribute types verify you have the default
   SHOW_BCODE using the YES_NO authorized value
2. Tools - Batch patron modification, add a patron card number or
   borrowernumber and continue
3. For Patron attribute select Show barcode on the summary screen item
   listings, and note that you get a blank text input rather than a select
   menu with Yes and No choices
4. Apply patch, restart_all
5. Repeat step 2 and 3, but note that you now get a Yes/No select menu

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 5 Emily Lamancusa (emlam) 2024-06-20 20:38:07 UTC
Thanks for the quick fix! Passing QA
Comment 6 Katrin Fischer 2024-06-21 13:04:49 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Lucas Gass (lukeg) 2024-07-18 19:24:52 UTC
Backported to 24.05.x for upcoming 24.05.02
Comment 8 Fridolin Somers 2024-07-19 08:35:20 UTC
Full CSRF not in 23.11.x
Comment 9 David Nind 2024-07-22 03:59:55 UTC
No changes required to the manual - the screenshots for the batch patron modification form are current.