If you have a patron attribute linked to an authorized value (like we do by default for "Show barcode on the summary screen items listings") then in patron batch modification rather than getting a select menu to choose an authorized value to change to, you just get a text input, thanks to a stray cud-.
Created attachment 167885 [details] [review] Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification Test plan: 1. In Administration - Patron attribute types verify you have the default SHOW_BCODE using the YES_NO authorized value 2. Tools - Batch patron modification, add a patron card number or borrowernumber and continue 3. For Patron attribute select Show barcode on the summary screen item listings, and note that you get a blank text input rather than a select menu with Yes and No choices 4. Apply patch, restart_all 5. Repeat step 2 and 3, but note that you now get a Yes/No select menu
Created attachment 167894 [details] [review] Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification Test plan: 1. In Administration - Patron attribute types verify you have the default SHOW_BCODE using the YES_NO authorized value 2. Tools - Batch patron modification, add a patron card number or borrowernumber and continue 3. For Patron attribute select Show barcode on the summary screen item listings, and note that you get a blank text input rather than a select menu with Yes and No choices 4. Apply patch, restart_all 5. Repeat step 2 and 3, but note that you now get a Yes/No select menu Signed-off-by: David Nind <david@davidnind.com>
Thanks Phil for adding a patch so quickly to fix this!
Created attachment 167941 [details] [review] Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification Test plan: 1. In Administration - Patron attribute types verify you have the default SHOW_BCODE using the YES_NO authorized value 2. Tools - Batch patron modification, add a patron card number or borrowernumber and continue 3. For Patron attribute select Show barcode on the summary screen item listings, and note that you get a blank text input rather than a select menu with Yes and No choices 4. Apply patch, restart_all 5. Repeat step 2 and 3, but note that you now get a Yes/No select menu Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Thanks for the quick fix! Passing QA
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.02
Full CSRF not in 23.11.x
No changes required to the manual - the screenshots for the batch patron modification form are current.