Bug 37172

Summary: HoldItem and HoldTitle do not check all the values of "hold_fulfillment_policy" rule
Product: Koha Reporter: Arthur Suzuki <arthur.suzuki>
Component: Web servicesAssignee: Arthur Suzuki <arthur.suzuki>
Status: ASSIGNED --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28504
Change sponsored?: Sponsored Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Attachments: Bug 37172 - HoldItem and HoldTitle do not check all the values of "hold_fulfillment_policy" rule

Description Arthur Suzuki 2024-06-24 13:51:44 UTC
values "homebranch" and "holdingbranch" are not checked, leading to forbidden holds to be put from the ILS-DI interface.

I think the controls on "hold_fulfillment_policy" should be done in "CanItemBeReserved" rather than "CheckReserves".
Comment 1 Arthur Suzuki 2024-06-24 13:56:12 UTC
Created attachment 168013 [details] [review]
Bug 37172 - HoldItem and HoldTitle do not check all the values of "hold_fulfillment_policy" rule
Comment 2 Fridolin Somers 2024-07-03 09:45:18 UTC
Yop

You must fix commit message ( : not - )

See
https://wiki.koha-community.org/wiki/Commit_messages#Subject_line
Comment 3 Fridolin Somers 2024-09-12 12:54:55 UTC
+    # Pickup branch management}
Typo ?