Summary: | 'datetime' field lost on pseudonymization | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Transaction logs | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, david, fridolin.somers, lucas, nick, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes a regression where the datetime field was lost when using the pseudonymization command line script added in Koha 24.05 (misc/maintenance/pseudonymize_statistics.pl, see bug 34611). It also adds new tests.
|
Version(s) released in: |
24.11.00,24.05.02
|
Circulation function: | |||
Bug Depends on: | 34611 | ||
Bug Blocks: | |||
Attachments: |
Bug 37182: Regression tests
Bug 37182: Make Koha::Statistic->new preserve 'datetime' if passed Bug 37182: Regression tests Bug 37182: Make Koha::Statistic->new preserve 'datetime' if passed |
Description
Tomás Cohen Arazi (tcohen)
2024-06-25 14:23:01 UTC
Created attachment 168094 [details] [review] Bug 37182: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 168095 [details] [review] Bug 37182: Make Koha::Statistic->new preserve 'datetime' if passed This patch does what the title says. This behavior is tested on the previous patch. Tests are also added for the background job (which relies on Koha::Statistic->new and was the evidence of this overwrite behavior). To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Statistic.t \ t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t => FAIL: Tests don't pass :-/ 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Created attachment 168114 [details] [review] Bug 37182: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 168115 [details] [review] Bug 37182: Make Koha::Statistic->new preserve 'datetime' if passed This patch does what the title says. This behavior is tested on the previous patch. Tests are also added for the background job (which relies on Koha::Statistic->new and was the evidence of this overwrite behavior). To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Statistic.t \ t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t => FAIL: Tests don't pass :-/ 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Straightforward and covered by tests, straight to PQA Pushed for 24.11! Well done everyone, thank you! Backported to 24.05.x for upcoming 24.05.02 No change to the manual required - fixing a regression. |