Created attachment 168094 [details] [review] Bug 37182: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 168095 [details] [review] Bug 37182: Make Koha::Statistic->new preserve 'datetime' if passed This patch does what the title says. This behavior is tested on the previous patch. Tests are also added for the background job (which relies on Koha::Statistic->new and was the evidence of this overwrite behavior). To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Statistic.t \ t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t => FAIL: Tests don't pass :-/ 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D
Created attachment 168114 [details] [review] Bug 37182: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 168115 [details] [review] Bug 37182: Make Koha::Statistic->new preserve 'datetime' if passed This patch does what the title says. This behavior is tested on the previous patch. Tests are also added for the background job (which relies on Koha::Statistic->new and was the evidence of this overwrite behavior). To test: 1. Apply the regression tests patch 2. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Statistic.t \ t/db_dependent/Koha/BackgroundJob/PseudonymizeStatistic.t => FAIL: Tests don't pass :-/ 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Straightforward and covered by tests, straight to PQA
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.02
Depends on Bug 34611 not in 23.11.x
No change to the manual required - fixing a regression.