| Summary: | All notes in the patron Transactions table should be editable | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
| Component: | Fines and fees | Assignee: | Sam Lau <samalau> |
| Status: | Signed Off --- | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | andrew, cubingguy714, roman.dolny, samalau |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 23674 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 37211: Make notes in patron transactions table editable
Bug 37211: Add new subpermission in updatecharge 'edit_notes' Bug 37211: Make notes in patron transactions table editable Bug 37211: Add new subpermission in updatecharge 'edit_notes' Bug 37211: Make notes in patron transactions table editable Bug 37211: Add new subpermission in updatecharge 'edit_notes' |
||
|
Description
Lucas Gass (lukeg)
2024-06-27 14:44:24 UTC
Created attachment 168211 [details] [review] Bug 37211: Make notes in patron transactions table editable This patch adds an edit button to each notes field in an accountline entry. This feature is controlled by a new staff permision under the 'updatecharges' permision called 'edit_notes'. To test: 1) Apply patch, updatedatabase, restart_all 2) In the staff interface, give your logged in user superlibrarian permissions. 3) Visit a patron's accounting tab. Create a manual invoice for some amount and enter a note. 4) Create another manual invoice, this time do not enter a note. 5) Click on the transactions tab to view the table. 6) See that the notes column now has edit buttons. 7) Attempt to edit the note that is not blank. 8) A modal should pop up prompting you to edit your note. The previous note should be in the text box. 9) Edit this note and press confirm. 10) Ensure the note was updated and the updated column was filled with the correct time. 11) Now attempt to edit the blank note. 12) Again, you should see a modal but no prefilled message. Update this note and ensure correct changes. 13) Go back to the permissions for your logged in user and remove the 'edit_notes' subpermission under the 'updatecharges' permissions. 14) Go back to the patron's accounting tab. This time, there should not be any edit buttons in the notes column. Created attachment 168212 [details] [review] Bug 37211: Add new subpermission in updatecharge 'edit_notes' Applying: Bug 37211: Make notes in patron transactions table editable error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt). error: could not build fake ancestor Patch failed at 0001 Bug 37211: Make notes in patron transactions table editable Created attachment 170002 [details] [review] Bug 37211: Make notes in patron transactions table editable This patch adds an edit button to each notes field in an accountline entry. This feature is controlled by a new staff permision under the 'updatecharges' permision called 'edit_notes'. To test: 1) Apply patch, updatedatabase, restart_all 2) In the staff interface, give your logged in user superlibrarian permissions. 3) Visit a patron's accounting tab. Create a manual invoice for some amount and enter a note. 4) Create another manual invoice, this time do not enter a note. 5) Click on the transactions tab to view the table. 6) See that the notes column now has edit buttons. 7) Attempt to edit the note that is not blank. 8) A modal should pop up prompting you to edit your note. The previous note should be in the text box. 9) Edit this note and press confirm. 10) Ensure the note was updated and the updated column was filled with the correct time. 11) Now attempt to edit the blank note. 12) Again, you should see a modal but no prefilled message. Update this note and ensure correct changes. 13) Go back to the permissions for your logged in user and remove the 'edit_notes' subpermission under the 'updatecharges' permissions. 14) Go back to the patron's accounting tab. This time, there should not be any edit buttons in the notes column. Created attachment 170003 [details] [review] Bug 37211: Add new subpermission in updatecharge 'edit_notes' Applying: Bug 37211: Add new subpermission in updatecharge 'edit_notes' error: sha1 information is lacking or useless (installer/data/mysql/mandatory/userpermissions.sql). error: could not build fake ancestor Patch failed at 0001 Bug 37211: Add new subpermission in updatecharge 'edit_notes' (In reply to Eric Garcia from comment #6) > Applying: Bug 37211: Add new subpermission in updatecharge 'edit_notes' > error: sha1 information is lacking or useless > (installer/data/mysql/mandatory/userpermissions.sql). > error: could not build fake ancestor > Patch failed at 0001 Bug 37211: Add new subpermission in updatecharge > 'edit_notes' I'm not getting this... maybe try a 'git pull'? Created attachment 170218 [details] [review] Bug 37211: Make notes in patron transactions table editable This patch adds an edit button to each notes field in an accountline entry. This feature is controlled by a new staff permision under the 'updatecharges' permision called 'edit_notes'. To test: 1) Apply patch, updatedatabase, restart_all 2) In the staff interface, give your logged in user superlibrarian permissions. 3) Visit a patron's accounting tab. Create a manual invoice for some amount and enter a note. 4) Create another manual invoice, this time do not enter a note. 5) Click on the transactions tab to view the table. 6) See that the notes column now has edit buttons. 7) Attempt to edit the note that is not blank. 8) A modal should pop up prompting you to edit your note. The previous note should be in the text box. 9) Edit this note and press confirm. 10) Ensure the note was updated and the updated column was filled with the correct time. 11) Now attempt to edit the blank note. 12) Again, you should see a modal but no prefilled message. Update this note and ensure correct changes. 13) Go back to the permissions for your logged in user and remove the 'edit_notes' subpermission under the 'updatecharges' permissions. 14) Go back to the patron's accounting tab. This time, there should not be any edit buttons in the notes column. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Created attachment 170219 [details] [review] Bug 37211: Add new subpermission in updatecharge 'edit_notes' Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> |