Bug 37260

Summary: Problem with connection to broker not displayed on the about page
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Pedro Amorim <pedro.amorim>
Status: RESOLVED FIXED QA Contact: Emily Lamancusa (emlam) <emily.lamancusa>
Severity: major    
Priority: P5 - low CC: caroline.cyr-la-rose, emily.lamancusa, fridolin.somers, lucas, pedro.amorim
Version: Main   
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.04
Circulation function:
Bug Depends on: 32693    
Bug Blocks: 38988    
Attachments: Bug 37260: [DONT PUSH] Test only
Bug 37260: Move setting of warnConnectBroker to 'about' block
Bug 37260: Check message broker for both 'about' and 'sysinfo' tabs
Bug 37260: Check message broker for both 'about' and 'sysinfo' tabs
Bug 37260: Check message broker for both 'about' and 'sysinfo' tabs

Description Jonathan Druart 2024-07-05 09:05:05 UTC
"Using SQL polling" is displayed if warnConnectBroker is set, but this flag is only set if we are on the sysinfo tab, not the first ('about') tab.
Comment 1 Pedro Amorim 2024-07-05 09:52:13 UTC
Created attachment 168529 [details] [review]
Bug 37260: [DONT PUSH] Test only

Force fail of BackgroundJob connect
Comment 2 Pedro Amorim 2024-07-05 09:52:16 UTC
Created attachment 168530 [details] [review]
Bug 37260: Move setting of warnConnectBroker to 'about' block

Test plan:
1) Apply test patch only
2) Visit <staff_url>/cgi-bin/koha/about.pl
3) Notice it shows 'Using RabbitMQ' (it should show 'Using SQL polling')
4) Apply this patch, repeat 3)
5) Notice it now shows 'Using SQL polling'
6) Remove test patch. Notice it shows 'Using RabbitMQ' again.
Comment 3 Jonathan Druart 2024-07-05 11:34:27 UTC
No, we need it for both.

See about.tt
 424             [% IF warnConnectBroker %]
 425                 <h2>Impossible to connect to the message broker</h2>
Comment 4 Pedro Amorim 2024-07-05 13:29:20 UTC
Created attachment 168549 [details] [review]
Bug 37260: Check message broker for both 'about' and 'sysinfo' tabs

Test plan:
1) Apply test patch only
2) Visit <staff_url>/cgi-bin/koha/about.pl
3) Notice it shows 'Using RabbitMQ' (it should show 'Using SQL polling')
4) Apply this patch, repeat 3)
5) Notice it now shows 'Using SQL polling'
6) Remove test patch. Notice it shows 'Using RabbitMQ' again.
7) Repeat test plan but for /cgi-bin/koha/about.pl?tab=sysinfo tab
Comment 5 Jonathan Druart 2024-07-05 13:38:00 UTC
Created attachment 168550 [details] [review]
Bug 37260: Check message broker for both 'about' and 'sysinfo' tabs

Test plan:
1) Apply test patch only
2) Visit <staff_url>/cgi-bin/koha/about.pl
3) Notice it shows 'Using RabbitMQ' (it should show 'Using SQL polling')
4) Apply this patch, repeat 3)
5) Notice it now shows 'Using SQL polling'
6) Remove test patch. Notice it shows 'Using RabbitMQ' again.
7) Repeat test plan but for /cgi-bin/koha/about.pl?tab=sysinfo tab

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Emily Lamancusa (emlam) 2024-07-18 20:24:43 UTC
Created attachment 169167 [details] [review]
Bug 37260: Check message broker for both 'about' and 'sysinfo' tabs

Test plan:
1) Apply test patch only
2) Visit <staff_url>/cgi-bin/koha/about.pl
3) Notice it shows 'Using RabbitMQ' (it should show 'Using SQL polling')
4) Apply this patch, repeat 3)
5) Notice it now shows 'Using SQL polling'
6) Remove test patch. Notice it shows 'Using RabbitMQ' again.
7) Repeat test plan but for /cgi-bin/koha/about.pl?tab=sysinfo tab

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 7 Emily Lamancusa (emlam) 2024-07-18 20:25:36 UTC
Looks good, works, and QA tool is happy. Passing QA
Comment 8 Martin Renvoize (ashimema) 2024-07-22 06:38:00 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 9 Lucas Gass (lukeg) 2024-08-28 19:39:38 UTC
Backported to 24.05.x for upcoming 24.05.04
Comment 10 Fridolin Somers 2024-09-10 13:08:46 UTC
Depends on Bug 37260 not in 23.11.x
Comment 11 Caroline Cyr La Rose 2024-09-10 20:18:59 UTC
This looks like a bug fix. Nothing to add/edit in the manual.