"Using SQL polling" is displayed if warnConnectBroker is set, but this flag is only set if we are on the sysinfo tab, not the first ('about') tab.
Created attachment 168529 [details] [review] Bug 37260: [DONT PUSH] Test only Force fail of BackgroundJob connect
Created attachment 168530 [details] [review] Bug 37260: Move setting of warnConnectBroker to 'about' block Test plan: 1) Apply test patch only 2) Visit <staff_url>/cgi-bin/koha/about.pl 3) Notice it shows 'Using RabbitMQ' (it should show 'Using SQL polling') 4) Apply this patch, repeat 3) 5) Notice it now shows 'Using SQL polling' 6) Remove test patch. Notice it shows 'Using RabbitMQ' again.
No, we need it for both. See about.tt 424 [% IF warnConnectBroker %] 425 <h2>Impossible to connect to the message broker</h2>
Created attachment 168549 [details] [review] Bug 37260: Check message broker for both 'about' and 'sysinfo' tabs Test plan: 1) Apply test patch only 2) Visit <staff_url>/cgi-bin/koha/about.pl 3) Notice it shows 'Using RabbitMQ' (it should show 'Using SQL polling') 4) Apply this patch, repeat 3) 5) Notice it now shows 'Using SQL polling' 6) Remove test patch. Notice it shows 'Using RabbitMQ' again. 7) Repeat test plan but for /cgi-bin/koha/about.pl?tab=sysinfo tab
Created attachment 168550 [details] [review] Bug 37260: Check message broker for both 'about' and 'sysinfo' tabs Test plan: 1) Apply test patch only 2) Visit <staff_url>/cgi-bin/koha/about.pl 3) Notice it shows 'Using RabbitMQ' (it should show 'Using SQL polling') 4) Apply this patch, repeat 3) 5) Notice it now shows 'Using SQL polling' 6) Remove test patch. Notice it shows 'Using RabbitMQ' again. 7) Repeat test plan but for /cgi-bin/koha/about.pl?tab=sysinfo tab Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 169167 [details] [review] Bug 37260: Check message broker for both 'about' and 'sysinfo' tabs Test plan: 1) Apply test patch only 2) Visit <staff_url>/cgi-bin/koha/about.pl 3) Notice it shows 'Using RabbitMQ' (it should show 'Using SQL polling') 4) Apply this patch, repeat 3) 5) Notice it now shows 'Using SQL polling' 6) Remove test patch. Notice it shows 'Using RabbitMQ' again. 7) Repeat test plan but for /cgi-bin/koha/about.pl?tab=sysinfo tab Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Looks good, works, and QA tool is happy. Passing QA
Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant
Backported to 24.05.x for upcoming 24.05.04
Depends on Bug 37260 not in 23.11.x
This looks like a bug fix. Nothing to add/edit in the manual.