Bug 37275

Summary: Remove parenthesis from Select user button in ERM
Product: Koha Reporter: Esther Melander <esther.melander>
Component: ERMAssignee: Eric Garcia <cubingguy714>
Status: Pushed to oldstable --- QA Contact: Martin Renvoize (ashimema) <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: jonathan.druart, jonathan.field, lucas, matt.blenkinsop, pedro.amorim
Version: MainKeywords: Academy
Hardware: All   
OS: All   
GIT URL: Change sponsored?: ---
Patch complexity: Trivial patch Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:
Attachments: Bug 37275: Removed parenthesis from Select user button in ERM
Bug 37275: Removed parenthesis from Select user button in ERM
Bug 37275: (QA follow-up): Add &nbsp; to add spacing between selected user and button
Bug 37275: Removed parenthesis from Select user button in ERM
Bug 37275: (QA follow-up): Add &nbsp; to add spacing between selected user and button

Description Esther Melander 2024-07-08 17:06:24 UTC
When managing Agreements or Licenses in the ERM, under Users, the +Select user button has extraneous parenthesis. These could be removed for a cleaner interface.
Comment 1 Eric Garcia 2024-07-11 15:50:31 UTC
Created attachment 168837 [details] [review]
Bug 37275: Removed parenthesis from Select user button in ERM

To test:
1. Apply patch and yarn build
2. In system preferences search and enable ERMModule
3. E-resource management -> Agreements -> New agreement
4. Click Add new user and notice the parenthesis around the +Select user button are removed
Comment 2 Pedro Amorim 2024-07-11 16:52:03 UTC
Created attachment 168849 [details] [review]
Bug 37275: Removed parenthesis from Select user button in ERM

To test:
1. Apply patch and yarn build
2. In system preferences search and enable ERMModule
3. E-resource management -> Agreements -> New agreement
4. Click Add new user and notice the parenthesis around the +Select user button are removed

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 3 Pedro Amorim 2024-07-11 16:52:06 UTC
Created attachment 168850 [details] [review]
Bug 37275: (QA follow-up): Add &nbsp; to add spacing between selected user and button

Follow original test plan and apply first patch.
Select a user and notice the patron's name and the button have no spacing.
Apply this patch.
Notice there is now spacing.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Martin Renvoize (ashimema) 2024-07-17 16:21:05 UTC
Created attachment 169103 [details] [review]
Bug 37275: Removed parenthesis from Select user button in ERM

To test:
1. Apply patch and yarn build
2. In system preferences search and enable ERMModule
3. E-resource management -> Agreements -> New agreement
4. Click Add new user and notice the parenthesis around the +Select user button are removed

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2024-07-17 16:21:07 UTC
Created attachment 169104 [details] [review]
Bug 37275: (QA follow-up): Add &nbsp; to add spacing between selected user and button

Follow original test plan and apply first patch.
Select a user and notice the patron's name and the button have no spacing.
Apply this patch.
Notice there is now spacing.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize (ashimema) 2024-07-17 16:21:23 UTC
Thanks for the fix, 

Passing QA
Comment 7 Katrin Fischer 2024-07-18 15:00:50 UTC
Hm, haven't tried, but would have expected the space here:

> <i class="fa fa-plus"></i> {{ $__("Select user") }}</a

Not sure if this gets lost with vue maybe.
Comment 8 Pedro Amorim 2024-07-18 15:45:47 UTC
(In reply to Katrin Fischer from comment #7)
> Hm, haven't tried, but would have expected the space here:
> 
> > <i class="fa fa-plus"></i> {{ $__("Select user") }}</a
> 
> Not sure if this gets lost with vue maybe.

I think the space there doesn't work on the final rendered HTML this is why I added the &nbsp;
Comment 9 Katrin Fischer 2024-07-18 15:57:14 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 10 Lucas Gass (lukeg) 2024-11-18 18:13:05 UTC
Backported to 24.05.x for upcoming 24.05.06