When managing Agreements or Licenses in the ERM, under Users, the +Select user button has extraneous parenthesis. These could be removed for a cleaner interface.
Created attachment 168837 [details] [review] Bug 37275: Removed parenthesis from Select user button in ERM To test: 1. Apply patch and yarn build 2. In system preferences search and enable ERMModule 3. E-resource management -> Agreements -> New agreement 4. Click Add new user and notice the parenthesis around the +Select user button are removed
Created attachment 168849 [details] [review] Bug 37275: Removed parenthesis from Select user button in ERM To test: 1. Apply patch and yarn build 2. In system preferences search and enable ERMModule 3. E-resource management -> Agreements -> New agreement 4. Click Add new user and notice the parenthesis around the +Select user button are removed Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 168850 [details] [review] Bug 37275: (QA follow-up): Add to add spacing between selected user and button Follow original test plan and apply first patch. Select a user and notice the patron's name and the button have no spacing. Apply this patch. Notice there is now spacing. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Created attachment 169103 [details] [review] Bug 37275: Removed parenthesis from Select user button in ERM To test: 1. Apply patch and yarn build 2. In system preferences search and enable ERMModule 3. E-resource management -> Agreements -> New agreement 4. Click Add new user and notice the parenthesis around the +Select user button are removed Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 169104 [details] [review] Bug 37275: (QA follow-up): Add to add spacing between selected user and button Follow original test plan and apply first patch. Select a user and notice the patron's name and the button have no spacing. Apply this patch. Notice there is now spacing. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks for the fix, Passing QA
Hm, haven't tried, but would have expected the space here: > <i class="fa fa-plus"></i> {{ $__("Select user") }}</a Not sure if this gets lost with vue maybe.
(In reply to Katrin Fischer from comment #7) > Hm, haven't tried, but would have expected the space here: > > > <i class="fa fa-plus"></i> {{ $__("Select user") }}</a > > Not sure if this gets lost with vue maybe. I think the space there doesn't work on the final rendered HTML this is why I added the
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06